[jira] [Commented] (HBASE-18216) [AMv2] Workaround for HBASE-18152, corrupt procedure WAL

[stack (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-18216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048712#comment-16048712
 ] 

stack commented on HBASE-18216:
-------------------------------

Subsequently pushed an addendum to the patch. This change:

diff --git 
a/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/ProcedureWALFormatReader.java
 
b/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/ProcedureWALFormatReader.jav
index c0540d9..fdbe03a 100644
--- 
a/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/ProcedureWALFormatReader.java
+++ 
b/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/ProcedureWALFormatReader.java
@@ -483,7 +483,7 @@ public class ProcedureWALFormatReader {
      */
     private static boolean isIncreasing(ProcedureProtos.Procedure current,
     ProcedureProtos.Procedure candidate) {
-      boolean increasing = current.getStackIdCount() < 
candidate.getStackIdCount() &&
+      boolean increasing = current.getStackIdCount() <= 
candidate.getStackIdCount() &&
         current.getLastUpdate() <= candidate.getLastUpdate();
       if (!increasing) {
         LOG.warn("NOT INCREASING! current=" + current + ", candidate=" + 
candidate);
@@ -868,4 +868,4 @@ public class ProcedureWALFormatReader {
       return (int)(Procedure.getProcIdHashCode(procId) % procedureMap.length);
     }
   }
-}
\ No newline at end of file
+}

Came of testing on cluster.

> [AMv2] Workaround for HBASE-18152, corrupt procedure WAL
> --------------------------------------------------------
>
>                 Key: HBASE-18216
>                 URL: https://issues.apache.org/jira/browse/HBASE-18216
>             Project: HBase
>          Issue Type: Bug
>          Components: proc-v2
>    Affects Versions: 2.0.0
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0
>
>
> Let me commit workaround for the issue up in HBASE-18152, corruption in the 
> master wal procedure files. Testing on cluster shows it helps.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)