[
https://issues.apache.org/jira/browse/HBASE-18217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049140#comment-16049140
]
Xiang Li commented on HBASE-18217:
----------------------------------
@phil yang, I need your help to confirm if the comment of "Time limit will be
500 ms." is not correct, as it was updated by HBASE-16051. I am a little
confused why the patch of HBASE-16051 changes CLIENT_TIMEOUT to 1000 and also
add the comment that "Time limit will be 500 ms.", seem not make sense.
Also, could you please explain a little more about the following comments on
DEFAULT_ROW_SLEEP_TIME
{code}
// So set this to 200, we will get 3 rows and reach time limit at the start
of 4th row, then sleep
// for the 4th time. Total time is 800 ms so we will not timeout.
{code}
you mentioned that it reaches "time limit" at the start of 4th row, it
conflicts with the last sentence saying that "Total time is 800 ms so we will
{color:red}not{color} timeout". If it reaches time limit, it will time out.
Please correct me if I did not get it right. When setting CLIENT_TIMEOUT to
1000, does it reach time limit at the start of 4th row (e.g. 600ms). Did you
write those when you perhaps assumed that CLIENT_TIMEOUT was 500?
> Correct comment errors in TestScannerHeartbeatMessages
> ------------------------------------------------------
>
> Key: HBASE-18217
> URL: https://issues.apache.org/jira/browse/HBASE-18217
> Project: HBase
> Issue Type: Bug
> Reporter: Xiang Li
> Assignee: Xiang Li
> Priority: Minor
>
> 1. For CLIENT_TIMEOUT
> {code}
> // Time, in milliseconds, that the client will wait for a response from the
> server before timing
> // out. This value is used server side to determine when it is necessary to
> send a heartbeat
> // message to the client. Time limit will be 500 ms.
> private static int CLIENT_TIMEOUT = 1000;
> {code}
> I think “Time limit will be 500 ms.” should be removed
> 2. For DEFAULT_ROW_SLEEP_TIME
> Typo, "same" -> "some", in
> // In this test, we sleep after reading each row. So we should make sure
> after we get some number
> // of rows and sleep {color:red}same{color} times we must reach time limit,
> and do not timeout after next sleeping.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
