[
https://issues.apache.org/jira/browse/HBASE-18209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049846#comment-16049846
]
Josh Elser commented on HBASE-18209:
------------------------------------
bq. This JIRA is to move to compile time dependency so that the corresponding
jars are bundled in lib directory.
If we just need to get these jars included in the tarball, we should update
hbase-assembly/pom.xml.
With your current patch, this would create a situation where the
maven-dependency-plugin's analyze phase would throw an error because
hbase-server would depend on JARs that it doesn't actually need. Since we
*know* that we need them at runtime, we should have hbase-assembly depend on
these two artifacts and (if necessary, I don't think it would be) add them to
{{hbase-assembly/src/main/assembly/hadoop-two-compat.xml}}.
So, we leave httpclient and httpcore as test-dependencies (as only
hbase-server/src/test/java requires it, not hbase-server/src/main/java) and
list the dependencies in hbase-assembly/pom.xml instead. Does this make sense?
I can put up a patch if not :)
Aside, it looks like commons-httpclient was upgraded in HBASE-16267 which means
that the version override (and comment) in hbase-server/pom.xml are
unnecessary. The version element and the comment should be removed as well for
org.apache.httpcomponents:httpclient.
> Make httpclient / httpcore compile time dependency
> --------------------------------------------------
>
> Key: HBASE-18209
> URL: https://issues.apache.org/jira/browse/HBASE-18209
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 18209.v1.txt
>
>
> We need httpclient & httpcore jars to be present when rootdir is placed on
> s3(a).
> Attempts to move to the fully shaded amazon-SDK JAR caused problems of its
> own. (according to [~steve_l])
> Here are the versions we should use:
> <commons.httpclient.version>4.5.2</commons.httpclient.version>
> <commons.httpcore.version>4.4.4</commons.httpcore.version>
> Currently they are declared test dependency.
> This JIRA is to move to compile time dependency so that the corresponding
> jars are bundled in lib directory.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
