[
https://issues.apache.org/jira/browse/HBASE-18170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052716#comment-16052716
]
Guanghao Zhang commented on HBASE-18170:
----------------------------------------
Attach a 005 patch which addressed [~stack]'s comments.
bq. no need of the Thread suffix I'd say
Great. Remove it in 005 patch. Thanks.
> Refactor ReplicationSourceWALReaderThread
> -----------------------------------------
>
> Key: HBASE-18170
> URL: https://issues.apache.org/jira/browse/HBASE-18170
> Project: HBase
> Issue Type: Improvement
> Reporter: Guanghao Zhang
> Assignee: Guanghao Zhang
> Attachments: HBASE-18170.master.001.patch,
> HBASE-18170.master.001.patch, HBASE-18170.master.002.patch,
> HBASE-18170.master.002.patch, HBASE-18170.master.003.patch,
> HBASE-18170.master.004.patch, HBASE-18170.master.005.patch
>
>
> HBASE-18130 add some get* method to ReplicationSource. So
> ReplicationSourceWALReaderThread doesn't need so many parameter to
> initialize. And the WALEntryFilter only used by
> ReplicationSourceWALReaderThread, so we don't need to new it for every
> ReplicationSourceWALReaderThread. Meanwhile, we can separate a new
> RecoveredReplicationSourceWALReaderThread for recovered replication source.
> Thanks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
