[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063810#comment-16063810
]
Mike Drob commented on HBASE-18175:
-----------------------------------
Do we know why findbugs isn't working? I couldn't get it to save locally either.
Usages of SerializableWritable, Pair, Tuple2 should be use generics. Lines 169,
263, 301, 302, 329, 337.
Line 172: use diamond operator HashMap<>()
Line 213: use diamond operator LinkedList<>()
Line 537: should be Long::equals instead of ==
Can we reuse any of the static classes from ITBulkLoad? Looking at LinkKey,
LinkChain specifically. Maybe {{class SparkLinkKey extends LinkKey implements
Serializable}} will be sufficient?
> Add hbase-spark integration test into hbase-spark-it
> ----------------------------------------------------
>
> Key: HBASE-18175
> URL: https://issues.apache.org/jira/browse/HBASE-18175
> Project: HBase
> Issue Type: Test
> Components: spark
> Reporter: Yi Liang
> Assignee: Yi Liang
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: hbase-18175-master-v2.patch,
> hbase-18175-master-v3.patch, hbase-18175-v1.patch
>
>
> After HBASE-17574, all test under hbase-spark are regarded as unit test, and
> this jira will add integration test of hbase-spark into hbase-it. This patch
> run same tests as mapreduce.IntegrationTestBulkLoad, just change mapreduce to
> spark.
> test in Maven:
> mvn verify -Dit.test=IntegrationTestSparkBulkLoad
> test on cluster:
> spark-submit --class
> org.apache.hadoop.hbase.spark.IntegrationTestSparkBulkLoad
> HBASE_HOME/lib/hbase-it-2.0.0-SNAPSHOT-tests.jar
> -Dhbase.spark.bulkload.chainlength=500000 -m slowDeterministic
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
