[
https://issues.apache.org/jira/browse/HBASE-18274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064939#comment-16064939
]
Hadoop QA commented on HBASE-18274:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 27s
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 9s
{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m 8s
{color} | {color:red} The patch generated 1 new + 497 unchanged - 1 fixed = 498
total (was 498) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
69m 46s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 71m 6s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:757bf37 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12874685/HBASE-18274.0.patch |
| JIRA Issue | HBASE-18274 |
| Optional Tests | asflicense shellcheck shelldocs |
| uname | Linux 0ede4482a408 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 873b15e |
| shellcheck | v0.4.6 |
| shellcheck |
https://builds.apache.org/job/PreCommit-HBASE-Build/7357/artifact/patchprocess/diff-patch-shellcheck.txt
|
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7357/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> hbase autorestart will overwirte the gc log
> -------------------------------------------
>
> Key: HBASE-18274
> URL: https://issues.apache.org/jira/browse/HBASE-18274
> Project: HBase
> Issue Type: Bug
> Components: hbase
> Affects Versions: 1.2.6, 1.1.11, 2.0.0-alpha-1
> Reporter: Fangyuan Deng
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18274.0.patch
>
>
> While using hbase autorestart , the gc log will be overwirited after the
> process(hmaster or hregionserver) retarting.
> This is because the autorestart loop is in internal_autostart function ( in
> hbase-daemon.sh), but we only rotate the gc log in autorestart function.
> (internal_autostart)
> ONE_HOUR_IN_SECS=3600
> autostartWindowStartDate=`date +%s`
> autostartCount=0
> touch "$HBASE_AUTOSTART_FILE"
> # keep starting the command until asked to stop. Reloop on software crash
> while true
> do
> code # restart the hbase process util the cluster is shut down
> fi
> (autorestart)
> echo running $command, logging to $HBASE_LOGOUT
> # stop the command
> $thiscmd --config "${HBASE_CONF_DIR}" stop $command $args &
> wait_until_done $!
> # wait a user-specified sleep period
> sp=${HBASE_RESTART_SLEEP:-3}
> if [ $sp -gt 0 ]; then
> sleep $sp
> fi
> check_before_start
> hbase_rotate_log $HBASE_LOGOUT
> hbase_rotate_log $HBASE_LOGGC
> nohup $thiscmd --config "${HBASE_CONF_DIR}" --autostart-window-size
> ${AUTOSTART_WINDOW_SIZE} --autostart-window-retry-limit
> ${AUTOSTART_WINDOW_RETRY_LIMIT} \
> internal_autostart $command $args < /dev/null > ${HBASE_LOGOUT} 2>&1
> &
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
