[
https://issues.apache.org/jira/browse/HBASE-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180055#comment-13180055
]
[email protected] commented on HBASE-3949:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3398/#review4193
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<https://reviews.apache.org/r/3398/#comment9448>
I don't think it makes sense to push this as a servlet context attribute --
instead, the servlet can read it directly from the configuration itself, right?
The context attributes are better for the "macro level" wiring of components.
src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java
<https://reviews.apache.org/r/3398/#comment9449>
style nit: spaces after commas
- Todd
On 2012-01-05 00:49:39, Gregory Chanan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3398/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-05 00:49:39)
bq.
bq.
bq. Review request for hbase, Todd Lipcon and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch addresses HBASE-3949: Add "Master" link to RegionServer pages
bq.
bq. I used the first suggestion in the patch, "use the RS local config setting"
bq.
bq.
bq. This addresses bug HBASE-3949.
bq. https://issues.apache.org/jira/browse/HBASE-3949
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon
24caabd
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
6ac23d6
bq. src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java
0f1fd04
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java
64e61bb
bq.
bq. Diff: https://reviews.apache.org/r/3398/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. - Ran unit test TestRSStatusServlet.java {Passed}
bq.
bq. - Ran a few simple configurations:
bq. - No hbase.master.info.port specified (default) {Link worked}
bq. - hbase.master.info.port specified and > 0 {Link worked}
bq. - hbase.master.info.port specified and < 0 {Printed proper message}
bq.
bq.
bq. Thanks,
bq.
bq. Gregory
bq.
bq.
> Add "Master" link to RegionServer pages
> ---------------------------------------
>
> Key: HBASE-3949
> URL: https://issues.apache.org/jira/browse/HBASE-3949
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.90.3, 0.92.0
> Reporter: Lars George
> Assignee: Gregory Chanan
> Priority: Minor
> Labels: noob
>
> Use the ZK info where the master is to add a UI link on the top of each
> RegionServer page. Currently you cannot navigate directly to the Master UI
> once you are on a RS page.
> Not sure if the info port is exposed OTTOMH, but we could either use the RS
> local config setting for that or add it to ZK to enable lookup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
