[ 
https://issues.apache.org/jira/browse/HBASE-16120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071940#comment-16071940
 ] 

Ashish Singhi commented on HBASE-16120:
---------------------------------------

I don't think the patch is really testing the behavior of truncate_preserve 
command. The test you have added is same as truncate command.
Correct me if I am missing something ?
I think in the test for truncate_preserve we need to assert that the table 
after truncate_preserve, still maintains the previous region boundaries as it 
was before.


> Add shell test for truncate_preserve
> ------------------------------------
>
>                 Key: HBASE-16120
>                 URL: https://issues.apache.org/jira/browse/HBASE-16120
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 1.4.0
>            Reporter: Appy
>            Assignee: Guangxu Cheng
>            Priority: Minor
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-16120-master-v0.patch, 
> HBASE-16120-master-v0.patch, HBASE-16120-master-v0.patch
>
>
> There's no shell test for truncate_preserve, should add one.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to