[
https://issues.apache.org/jira/browse/HBASE-17908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075458#comment-16075458
]
stack commented on HBASE-17908:
-------------------------------
Thank you for review [~jerryhe]
bq. At the end of this, we will still have the Guava (non-shaded, old version)
as dependency, from hadoop-common?
Yes sir. We won't be using it other than indirectly. Hadoop Configuration uses
the guava precondition so it needs the old guava but our guava use is relocated
so we'll not use hadoop's guava. I spent a bit of effort shutting down all
transitive includes of guavas so it only comes in w/ hadoop-common references.
bq. What are all the changes in hbase-protocol-shaded, generated and non
generated?
Ripples from move from protobuf 3.2.0 to 3.3.0. I updated the protobuf we were
referencing to match the protobuf that is brought in via hbase-thirdparty just
in case the diff would make any issues.
All this stuff gets expunged by the concurrent removal of all checked-in
generated files, HBASE-17056.
Thanks Jerry.
> Upgrade guava
> -------------
>
> Key: HBASE-17908
> URL: https://issues.apache.org/jira/browse/HBASE-17908
> Project: HBase
> Issue Type: Sub-task
> Components: dependencies
> Reporter: Balazs Meszaros
> Assignee: stack
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-17908.master.001.patch,
> HBASE-17908.master.002.patch, HBASE-17908.master.003.patch,
> HBASE-17908.master.004.patch, HBASE-17908.master.005.patch,
> HBASE-17908.master.006.patch, HBASE-17908.master.007.patch,
> HBASE-17908.master.008.patch, HBASE-17908.master.009.patch,
> HBASE-17908.master.010.patch, HBASE-17908.master.011.patch,
> HBASE-17908.master.012.patch, HBASE-17908.master.013.patch,
> HBASE-17908.master.013.patch, HBASE-17908.master.014.patch,
> HBASE-17908.master.015.patch, HBASE-17908.master.015.patch,
> HBASE-17908.master.016.patch, HBASE-17908.master.017.patch
>
>
> Currently we are using guava 12.0.1, but the latest version is 21.0.
> Upgrading guava is always a hassle because it is not always backward
> compatible with itself.
> Currently I think there are to approaches:
> 1. Upgrade guava to the newest version (21.0) and shade it.
> 2. Upgrade guava to a version which does not break or builds (15.0).
> If we can update it, some dependencies should be removed:
> commons-collections, commons-codec, ...
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
