[
https://issues.apache.org/jira/browse/HBASE-18324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075549#comment-16075549
]
stack commented on HBASE-18324:
-------------------------------
Oh. Sweet. Something to work with. On not having excludes, it might be ok since
if you are referring to com.google.protobuf, then you need to be in the
hbase-endpoint module... or in your own purposed module... i.e. outside of the
hbase-server, et al. Let me play w/ this and errorprone.... see if I can come
up w/ something. Thanks lads.
> [hbase-thirdparty] Tooling to prevent commits that mistakenly make use of
> unshaded protobuf/guava/etc.
> ------------------------------------------------------------------------------------------------------
>
> Key: HBASE-18324
> URL: https://issues.apache.org/jira/browse/HBASE-18324
> Project: HBase
> Issue Type: Bug
> Reporter: stack
>
> Chatting w/ [~mdrob], he brought up the question of what if a dev makes use
> of unshaded protobuf or guava? Afterall, the old jars (pb2.5 and hadoops
> guava12.0 or whatever) are still on the CLASSPATH because upstream depends on
> them.
> We could add a check as part of prebuild. It would complain if use of
> com.google instead of org.apache.hadoop.hbase.shaded.com.google. But even
> then, there are cases where com.google is legit (coprocessor endpoints) so it
> would have to let these pass.
> TODO.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
