[
https://issues.apache.org/jira/browse/HBASE-18107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075546#comment-16075546
]
Yi Liang edited comment on HBASE-18107 at 7/5/17 11:35 PM:
-----------------------------------------------------------
Hi [~stack], below is my finds about this DispatchMergingRegions
here is the 2 execute paths of merge in two branches
{quote}
In branch-1.2:
HBaseAdmin.mergeRegions
-> MasterKeepAliveConnection.dispatchMergingRegions
-> MasterRpcServices.dispatchMergingRegions
-> HMaster.dispatchMergingRegions
-> DispatchMergingRegionHandler
In branch master:
HBaseAdmin.mergeRegionsAsync
-> MasterKeepAliveConnection.mergeTableRegions
-> MasterRpcServices.mergeTableRegions
-> HMaster.mergeRegions
-> MasterProcedureUtil.submitProcedure
{quote}
It seems that [~syuanjiang] have replaced dispatchMergingRegions with
MergeTableRegionsProcedure, followed by the history of merge procedure:
In HBASE-14552,The DispatchMergingRegionHandler has been replaced with
DispatchMergingRegionsProcedure
In HBASE-16119 DispatchMergingRegionsProcedure has been replaced with
MergeTableRegionsProcedure
In HBASE-17470 DispatchMergingRegionsProcedure has been removed
In HBASE-14614, it seems that DispatchMergingRegionsProcedure added back again
So from my point of view, we need to remove DispatchMergingRegionsProcedure
i.e we need to remove the path 2 of Merge Regions as I mentioned in HBASE-18105
was (Author: easyliangjob):
Hi [~stack], below is my finds about this DispatchMergingRegions
here is the 2 execute paths of merge in two branches
{quote}
In branch-1.2:
HBaseAdmin.mergeRegions
-> MasterKeepAliveConnection.dispatchMergingRegions
-> MasterRpcServices.dispatchMergingRegions
-> HMaster.dispatchMergingRegions
-> DispatchMergingRegionHandler
In branch master:
HBaseAdmin.mergeRegionsAsync
-> MasterKeepAliveConnection.mergeTableRegions
-> MasterRpcServices.mergeTableRegions
-> HMaster.mergeRegions
-> MasterProcedureUtil.submitProcedure
{quote}
It seems that [~syuanjiang] have replaced dispatchMergingRegions with
MergeTableRegionsProcedure, followed by the history of merge procedure:
In HBASE-14552,The DispatchMergingRegionHandler has been replaced with
DispatchMergingRegionsProcedure
In HBASE-16119 DispatchMergingRegionsProcedure has been replaced with
MergeTableRegionsProcedure
In HBASE-17470 DispatchMergingRegionsProcedure has been removed
In HBase-14614, it seems that DispatchMergingRegionsProcedure added back again
So from my point of view, we need to remove DispatchMergingRegionsProcedure
i.e we need to remove the path 2 of Merge Regions as I mentioned in HBASE-18105
> [AMv2] Rename DispatchMergingRegionsRequest & DispatchMergingRegions
> --------------------------------------------------------------------
>
> Key: HBASE-18107
> URL: https://issues.apache.org/jira/browse/HBASE-18107
> Project: HBase
> Issue Type: Sub-task
> Components: Region Assignment
> Affects Versions: 2.0.0
> Reporter: stack
> Fix For: 2.0.0
>
>
> They don't align with how we have named the Split equivalents; i.e.
> SplitRegion (so should be MergeRegion...). They probably have these awkward
> names because the obvious slots are occupied... so this may not be fixable
> but filing issue anyways.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
