[
https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077244#comment-16077244
]
Enis Soztutar commented on HBASE-10240:
---------------------------------------
I was doing some digging. Findings so far:
9e249881ef6a49879511be24e11d717738085dd5 (HBASE-7224) added this to the javadoc
for HbaseObjectWritableFor96Migration
{code}
* @deprecated This class is needed migrating TablePermissions written with
* Writables. It is needed to read old permissions written pre-0.96. This
* class is to be removed after HBase 0.96 ships since then all permissions
* will have been migrated and written with protobufs.
{code}
However, when reading the code {{TablePermissions}}, which extends
{{Permission}} which is still {{Writable}} and never made PB I guess. There is
also a couple of other Writables like AuthenticationKey.
It seems (from my reading of the code) that we are using PB's in the RPC, but
we are reading and writing these objects from the ACL table or ZK using
Writables. However, I think neither of these depends on
HbaseObjectWritableFor96Migration per se, so the patch maybe good as it is.
> Remove 0.94->0.96 migration code
> --------------------------------
>
> Key: HBASE-10240
> URL: https://issues.apache.org/jira/browse/HBASE-10240
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Peter Somogyi
> Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-10240.master.001.patch,
> HBASE-10240.master.001.patch
>
>
> Remove the objects and code only needed for supporting migration to 0.96 from
> 0.94.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
