[
https://issues.apache.org/jira/browse/HBASE-18327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077595#comment-16077595
]
Hadoop QA commented on HBASE-18327:
-----------------------------------
| (/) *{color:green} 1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
4s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green} 1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green} 1{color} | {color:green} shellcheck {color} | {color:green} 0m
5s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green} 1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green} 1{color} | {color:green} hadoopcheck {color} | {color:green}
31m 52s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green} 1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 32m 33s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:757bf37 |
| JIRA Issue | HBASE-18327 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12876025/HBASE-18327.2.patch |
| Optional Tests | asflicense shellcheck shelldocs |
| uname | Linux 7fd581506a6a 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 68436c9 |
| shellcheck | v0.4.6 |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7558/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> redo test-patch personality 'hadoopcheck' to better account for feature
> branches
> --------------------------------------------------------------------------------
>
> Key: HBASE-18327
> URL: https://issues.apache.org/jira/browse/HBASE-18327
> Project: HBase
> Issue Type: Improvement
> Components: build, test
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Minor
> Attachments: HBASE-18327.0.patch, HBASE-18327.1.patch,
> HBASE-18327.2.patch
>
>
> right now our 'which hadoop checks do we need' check looks like this:
> {code}
> if [[ "${PATCH_BRANCH}" = "master" ]]; then
> hbase_hadoop2_versions=${HBASE_MASTER_HADOOP2_VERSIONS}
> hbase_hadoop3_versions=${HBASE_MASTER_HADOOP3_VERSIONS}
> elif [[ ${PATCH_BRANCH} = branch-2* ]]; then
> hbase_hadoop2_versions=${HBASE_BRANCH2_HADOOP2_VERSIONS}
> hbase_hadoop3_versions=${HBASE_BRANCH2_HADOOP3_VERSIONS}
> else
> hbase_hadoop2_versions=${HBASE_HADOOP2_VERSIONS}
> hbase_hadoop3_versions=${HBASE_HADOOP3_VERSIONS}
> fi
> {code}
> the check is basically "if master do this, if like branch-2 do that,
> otherwise behave like branch-1".
> we often have feature branches that thus end up being treated like branch-1,
> even though those branches should all be based off of master. (since we
> follow a master-first development approach.)
> we should redo this check so it's "if branch-1 do this, if branch-2 do that,
> otherwise behave like master"
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
