[ 
https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079098#comment-16079098
 ] 

Chia-Ping Tsai commented on HBASE-17056:
----------------------------------------

I add the replacer plugin to v3.patch. And then TEST/COMPILE works currently. 
(don't need to run the mvn install first)
{code}
      <plugin> 
        <groupId>com.google.code.maven-replacer-plugin</groupId> 
        <artifactId>replacer</artifactId> 
        <version>1.5.3</version> 
        <executions> 
          <execution> 
            <phase>process-sources</phase> 
            <goals> 
              <goal>replace</goal> 
            </goals> 
          </execution> 
        </executions> 
        <configuration> 
          <basedir>${basedir}/target/generated-sources/</basedir>  
            <includes>  
                <include>**/*.java</include>  
            </includes>  
          <regex>false</regex>
          <token>com.google.protobuf</token> 
          <value>org.apache.hadoop.hbase.shaded.com.google.protobuf</value> 
        </configuration> 
      </plugin>
{code}

> Remove checked in PB generated files 
> -------------------------------------
>
>                 Key: HBASE-17056
>                 URL: https://issues.apache.org/jira/browse/HBASE-17056
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Enis Soztutar
>            Assignee: stack
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: 
> 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, 
> HBASE-17056.master.001.patch, HBASE-17056.master.002.patch, 
> HBASE-17056.master.003.patch
>
>
> Now that we have the new PB maven plugin, there is no need to have the PB 
> files checked in to the repo. The reason we did that was to ease up developer 
> env setup. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to