[
https://issues.apache.org/jira/browse/HBASE-18307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079830#comment-16079830
]
Guanghao Zhang commented on HBASE-18307:
----------------------------------------
bq. int workerCount = conf.getInt("hbase.netty.worker.count", 0);
The default thread number is 0?
bq. ServerBootstrap bootstrap = new
ServerBootstrap().group(eventLoopGroup).channel(channelClass)
Why acceptor and client use one EventLoopGroup?
How about add a helper class for passing config to NettyRpcServer, similar with
NettyRpcClientConfigHelper and NettyAsyncFSWALConfigHelper? Then we can remove
the cast code in NettyRpcServer.
> Share the same EventLoopGroup for NettyRpcServer, NettyRpcClient and
> AsyncFSWALProvider at RS side
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-18307
> URL: https://issues.apache.org/jira/browse/HBASE-18307
> Project: HBase
> Issue Type: Improvement
> Components: io, rpc, wal
> Affects Versions: 3.0.0, 2.0.0-alpha-1
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18307.patch, HBASE-18307-v1.patch
>
>
> Need a find a proper way to pass a EventLoopGroup instance through a
> Configuration object.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
