[
https://issues.apache.org/jira/browse/HBASE-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079876#comment-16079876
]
Anoop Sam John commented on HBASE-18295:
----------------------------------------
On the patch, now u put together 3 switch cases and within that if else
condition. That is done for sharing the new call to needToReturn(). But can
we do the old way of own switch case itself ? It is just 3 or 4 lines that u
can repeat. Than this way of case and within if else, that will be more easy
to read and understand.
{code}
if (nextKV != null) {
703 seekAsDirection(nextKV);
704 } else {
705 heap.next();
706 break;
707 }
{code}
What is that break?
> The result contains the cells across different rows
> ----------------------------------------------------
>
> Key: HBASE-18295
> URL: https://issues.apache.org/jira/browse/HBASE-18295
> Project: HBase
> Issue Type: Bug
> Affects Versions: 1.3.0, 1.3.1, 2.0.0-alpha-1
> Reporter: Chia-Ping Tsai
> Assignee: Chia-Ping Tsai
> Priority: Blocker
> Fix For: 3.0.0, 1.4.0, 1.3.2, 2.0.0-alpha-2
>
> Attachments: HBASE-18295.branch-1.3.v0.patch,
> HBASE-18295.branch-1.3.v1.patch, HBASE-18295.branch-1.v0.patch,
> HBASE-18295.branch-1.v1.patch, HBASE-18295.branch-1.v1.patch,
> HBASE-18295.branch-1.v1.patch, HBASE-18295.v0.patch, HBASE-18295.v1.patch,
> HBASE-18295.v2.patch, HBASE-18295.v2.patch
>
>
> From the [flaky
> dashboard|https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html]
> If we use the cell which won't be flushed into disk as the top cell to reopen
> the scanners, the new top cell will change. If the new top cell is in
> different row, the matcher will reset, and then matcher will accept the new
> top cell...
> The TestStore# testFlushBeforeCompletingScan reproduces the bug.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
