[
https://issues.apache.org/jira/browse/HBASE-18344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081808#comment-16081808
]
Chia-Ping Tsai commented on HBASE-18344:
----------------------------------------
LGTM. The deprecated API is used again in recent commit (HBASE-18267). Would
you please fix it?
{code:title=TestResultFromCoprocessor.java}
@Test
public void testAppend() throws IOException {
try (Table t = TEST_UTIL.getConnection().getTable(TABLE_NAME)) {
Put put = new Put(ROW);
put.addColumn(FAMILY, QUAL, VALUE);
t.put(put);
assertRowAndValue(t.get(new Get(ROW)), ROW, VALUE);
Append append = new Append(ROW);
append.add(FAMILY, QUAL, FIXED_VALUE);
assertRowAndValue(t.append(append), ROW, FIXED_VALUE);
assertRowAndValue(t.get(new Get(ROW)), ROW, Bytes.add(VALUE,
FIXED_VALUE));
}
}
{code}
> Replace Append#add(byte[], byte[], byte[]) by Append#addColumn
> --------------------------------------------------------------
>
> Key: HBASE-18344
> URL: https://issues.apache.org/jira/browse/HBASE-18344
> Project: HBase
> Issue Type: Task
> Reporter: Chia-Ping Tsai
> Assignee: Jan Hentschel
> Priority: Trivial
> Labels: beginner
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18344.master.001.patch
>
>
> We have Put#addColumn and Increment#addColumn but there is no
> Append#addColumn. We should add Append#addColumn for consistency.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
