[
https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HBASE-12349:
------------------------------
Attachment: HBASE-12349.v2.patch
Got this into a workable state, finally.
* Create new hbase-build-support module to hold hbase-error-prone.
** We need this so that we can separate the compilation configurations to
compile our rules using plain javac and compile the rest using javac+rules
** Eventually, we would move hbase-checkstyle and hbase-resource-bundle into
there also, I think.
* Created hbase-build-configuration module to hold the error-prone profile.
Moved all other modules to inherit from it instead of hbase-root.
** This can have other configurations in it that we don't want affecting the
build support modules, but I don't know what they'd be at this point. Even
without them, this is kind of clunky but still necessary, I think.
* While testing this, I ended up fixing a few error-prone bugs to make sure
that the results are actually correct. I can back them out and include them
separately, but it seems fine to include them. There's still plenty more follow
on work to be done.
* Added a placeholder custom error-prone rule that never fails. Can remove this
when we have other rules in place, but I wanted to have some java source
available.
Future work we will want to add @Generated to all of the protoc code, this will
speed up error-prone-javac a bit, and also start chopping away the reported
errors and then the warnings. There's plenty of work to do, unsure how much is
false positives and how much is true, but it's a non zero amount of actual bugs.
test-patch is very very likely to fail, we'll see if there's something I can
iterate on in this patch or wait until the next one.
> Add Maven build support module for a custom version of error-prone
> ------------------------------------------------------------------
>
> Key: HBASE-12349
> URL: https://issues.apache.org/jira/browse/HBASE-12349
> Project: HBase
> Issue Type: Sub-task
> Reporter: Andrew Purtell
> Assignee: Mike Drob
> Fix For: 2.0.0
>
> Attachments: HBASE-12349.patch, HBASE-12349.v2.patch
>
>
> Add a new Maven build support module that builds and publishes a custom
> error-prone artifact for use by the rest of the build.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
