[
https://issues.apache.org/jira/browse/HBASE-18367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088196#comment-16088196
]
stack commented on HBASE-18367:
-------------------------------
Making getState and isRunnable public seems small price to pay if can remove
use of PI.
Maybe s/CompletedProcedure/CompletedProcedureRetainer/ since it not a
Procedure... it just has one?
Should we add a method to the CompletedProcedure or whatever its called that is
like this:
boolean evict(long now);
... and inside it, it would do all the checks you have here:
189 if ((completedProcedure.hasClientAckTime() && (now -
completedProcedure.getClientAckTime()) >= evictAckTtl) ||
190 (now - proc.getLastUpdate()) >= evictTtl) {
Why a FailedProcedure ?
Nice cleanup in ProcedureStore and in ProcedureWALFormatReader
This looks like a good direction to me [~balazs.meszaros]
> Reduce ProcedureInfo usage
> --------------------------
>
> Key: HBASE-18367
> URL: https://issues.apache.org/jira/browse/HBASE-18367
> Project: HBase
> Issue Type: Sub-task
> Components: master, proc-v2
> Reporter: Balazs Meszaros
> Assignee: Balazs Meszaros
> Fix For: 2.0.0
>
> Attachments: HBASE-18367.001.patch, HBASE-18367.002.patch
>
>
> If we want to replace ProcedureInfo objects with jsons (HBASE-18106) we have
> to reduce ProcedureInfo usage. Currently it is used several places in the
> code where it could be replaced with Procedure (e.g. ProcedureExecutor). We
> should use ProcedureInfo only for the communication before removing it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
