[
https://issues.apache.org/jira/browse/HBASE-18392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090622#comment-16090622
]
Hadoop QA commented on HBASE-18392:
-----------------------------------
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
4s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
4s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
31m 35s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 32m 25s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:757bf37 |
| JIRA Issue | HBASE-18392 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12877672/HBASE-18392-master-001.patch
|
| Optional Tests | asflicense shellcheck shelldocs |
| uname | Linux 56cbbb2d7947 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 2d5a0fb |
| shellcheck | v0.4.6 |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7685/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Add default value of ----movetimeout to rolling-restart.sh
> ----------------------------------------------------------
>
> Key: HBASE-18392
> URL: https://issues.apache.org/jira/browse/HBASE-18392
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.0.0
> Reporter: Samir Ahmic
> Assignee: Samir Ahmic
> Fix For: 3.0.0
>
> Attachments: HBASE-18392-master-001.patch
>
>
> We are calling graceful_stop.sh in rolling-restart.sh with following line
> {code}
> "$bin"/graceful_stop.sh --config ${HBASE_CONF_DIR} --restart --reload -nob
> --maxthreads \
> ${RR_MAXTHREADS} ${RR_NOACK} --movetimeout ${RR_MOVE_TIMEOUT}
> $hostname
> {code}
> and if we not specified --movetimeout option while calling rolling-restart.sh
> --graceful script will not work. My propose is to add default value for this
> parameter same way we are doing in graceful_stop.sh
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
