[
https://issues.apache.org/jira/browse/HBASE-18338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090846#comment-16090846
]
Enis Soztutar commented on HBASE-18338:
---------------------------------------
- {{rpc.h -> rpc-serde.h}} this is good.
- Are these coming in this patch, or to be filled out later?
{code}
+ } else if (method_name == "error") {
+ //TODO:
+ } else if (method_name == "pause") {
+ //TODO:
+ } else if (method_name == "addr") {
+ //TODO:
+ }
{code}
- Should this default to 0 so that OS will select an empty port for the unit
test?
{code}
+DEFINE_int32(port, 8080, "test server port");
{code}
- This does not fail the unit test, probably re-throw?:
{code}
+ } catch (const std::exception& e) {
+ VLOG(2) << exceptionStr(e) << std::endl;
+ }
{code}
- Test server and handler looks good.
bq. So reviews can skip rpc-test-client.h and rpc-test-client-handler.h.
So, what is the plan for this patch? Commit these two classes for now, and
remove them in the follow up patch?
> [C++] Implement RpcTestServer
> -----------------------------
>
> Key: HBASE-18338
> URL: https://issues.apache.org/jira/browse/HBASE-18338
> Project: HBase
> Issue Type: Sub-task
> Reporter: Xiaobing Zhou
> Assignee: Xiaobing Zhou
> Attachments: HBASE-18338.000.patch, HBASE-18338.001.patch,
> HBASE-18338.002.patch, HBASE-18338.003.patch, HBASE-18338.004.patch
>
>
> This is a spin-off from HBASE-18078. We need RpcTestServer to simulate
> various communication scenarios, e.g. timeout, connection aborted, long
> running services and so on.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
