[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181881#comment-13181881 ]
Hadoop QA commented on HBASE-5134: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12509771/5134-v2.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -147 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 78 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestAssignmentManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/695//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/695//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/695//console This message is automatically generated. > Remove getRegionServerWithoutRetries and getRegionServerWithRetries from > HConnection Interface > ---------------------------------------------------------------------------------------------- > > Key: HBASE-5134 > URL: https://issues.apache.org/jira/browse/HBASE-5134 > Project: HBase > Issue Type: Improvement > Reporter: stack > Assignee: stack > Attachments: 5134-v2.txt > > > Its broke having these meta methods in HConnection. They take > ServerCallables which themselves have HConnections inevitably. It makes for > a tangle in the model and frustrates being able to do mocked implemenations > of HConnection. These methods better belong in something like > HConnectionManager, or elsewhere altogether. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira