[ 
https://issues.apache.org/jira/browse/HBASE-18303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095260#comment-16095260
 ] 

Mike Drob commented on HBASE-18303:
-----------------------------------

No, I only went through and fixed client, common, prefix-tree, and rest. The 
changes in hbase-server are from moving some things to hbase-common so had to 
update static references. Wanted to get some eyes on this before going through 
and tackling the rest of the modules.

> Clean up some parameterized test declarations
> ---------------------------------------------
>
>                 Key: HBASE-18303
>                 URL: https://issues.apache.org/jira/browse/HBASE-18303
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>            Reporter: Mike Drob
>            Assignee: Mike Drob
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-18303.patch, HBASE-18303.patch
>
>
> While debugging something unrelated, I noticed that we use the constructor 
> form of junit parameterized tests, instead of the annotated members form.
> I personally find using the @Parameter annotation more clear.
> Also, we can move the parameter generator to hbase-common so that it is 
> accessible in more modules.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to