[ 
https://issues.apache.org/jira/browse/HBASE-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096860#comment-16096860
 ] 

Misty Stanley-Jones commented on HBASE-18430:
---------------------------------------------

No worries. The sign-off is not a HBase requirement, just a personal preference 
for some of us. It just adds that little "Signed-off by" line to the commit 
message. It's actually something that happens during the {{git commit}}, not 
the {{git format-patch}}. Your {{git format-patch}} is perfect. If you commit 
and then realize you didn't sign off, you can do {{git commit --amend -s}}. I 
do that all the time. :) You can always look at your existing commit by doing 
{{git log -n1}}.

> Typo in "contributing to documentation" page
> --------------------------------------------
>
>                 Key: HBASE-18430
>                 URL: https://issues.apache.org/jira/browse/HBASE-18430
>             Project: HBase
>          Issue Type: Bug
>          Components: documentation
>            Reporter: Coral
>            Assignee: Coral
>             Fix For: 3.0.0, 2.0.0-alpha-2
>
>         Attachments: HBASE-18430.patch
>
>
> Be sure to set the component to Documentation in addition any other involved 
> components.
> Missing "to." Should be: 
> Be sure to set the component to Documentation in addition *to* any other 
> involved components.
> http://hbase.apache.org/book.html#appendix_contributing_to_documentation



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to