[ https://issues.apache.org/jira/browse/HBASE-18432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097120#comment-16097120 ]
Hadoop QA commented on HBASE-18432: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 20s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m 12s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 1s{color} | {color:green} HBASE-14070.HLC passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s{color} | {color:green} HBASE-14070.HLC passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 43s{color} | {color:green} HBASE-14070.HLC passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 36s{color} | {color:green} HBASE-14070.HLC passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 39s{color} | {color:red} hbase-server in HBASE-14070.HLC has 9 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 45s{color} | {color:green} HBASE-14070.HLC passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 16s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 0s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 40s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 29m 3s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 23s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 15s{color} | {color:red} hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 2m 14s{color} | {color:red} hbase-common in the patch failed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 71m 14s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 58s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}125m 5s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.TestTimestampType | | Timed out junit tests | org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure | | | org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay | | | org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure | | | org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure | | | org.apache.hadoop.hbase.regionserver.TestRowTooBig | | | org.apache.hadoop.hbase.regionserver.TestSplitLogWorker | | | org.apache.hadoop.hbase.regionserver.wal.TestAsyncWALReplay | | | org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence | | | org.apache.hadoop.hbase.coprocessor.TestHTableWrapper | | | org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy | | | org.apache.hadoop.hbase.mapreduce.TestHRegionPartitioner | | | org.apache.hadoop.hbase.mapreduce.TestTableInputFormat | | | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId | | | org.apache.hadoop.hbase.client.TestFromClientSide | | | org.apache.hadoop.hbase.client.TestMultipleTimestamps | | | org.apache.hadoop.hbase.client.TestAsyncTableScanAll | | | org.apache.hadoop.hbase.regionserver.TestCompaction | | | org.apache.hadoop.hbase.regionserver.wal.TestFSHLog | | | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 | | | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries | | | org.apache.hadoop.hbase.master.TestAssignmentManagerMetrics | | | org.apache.hadoop.hbase.master.assignment.TestAssignmentManager | | | org.apache.hadoop.hbase.quotas.TestSnapshotQuotaObserverChore | | | org.apache.hadoop.hbase.namespace.TestNamespaceAuditor | | | org.apache.hadoop.hbase.TestHBaseTestingUtility | | | org.apache.hadoop.hbase.mapred.TestTableInputFormat | | | org.apache.hadoop.hbase.client.TestAsyncProcedureAdminApi | | | org.apache.hadoop.hbase.client.TestAsyncTableBatch | | | org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook | | | org.apache.hadoop.hbase.TestFullLogReconstruction | | | org.apache.hadoop.hbase.regionserver.TestTimestampFilterSeekHint | | | org.apache.hadoop.hbase.regionserver.TestTags | | | org.apache.hadoop.hbase.master.TestMasterFileSystemWithWALDir | | | org.apache.hadoop.hbase.TestMultiVersions | | | org.apache.hadoop.hbase.quotas.TestQuotaStatusRPCs | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLablesWithGroups | | | org.apache.hadoop.hbase.security.visibility.TestEnforcingScanLabelGenerator | | | org.apache.hadoop.hbase.client.TestAsyncNonMetaRegionLocator | | | org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi | | | org.apache.hadoop.hbase.wal.TestWALFiltering | | | org.apache.hadoop.hbase.regionserver.wal.TestWALReplay | | | org.apache.hadoop.hbase.security.access.TestAccessController2 | | | org.apache.hadoop.hbase.mapred.TestTableMapReduceUtil | | | org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi | | | org.apache.hadoop.hbase.quotas.TestMasterSpaceQuotaObserver | | | org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi | | | org.apache.hadoop.hbase.mapreduce.TestCellCounter | | | org.apache.hadoop.hbase.master.TestGetInfoPort | | | org.apache.hadoop.hbase.client.TestAsyncRegionLocatorTimeout | | | org.apache.hadoop.hbase.client.TestAsyncQuotaAdminApi | | | org.apache.hadoop.hbase.client.TestAsyncTableAdminApi | | | org.apache.hadoop.hbase.wal.TestWALSplitCompressed | | | org.apache.hadoop.hbase.TestZooKeeper | | | org.apache.hadoop.hbase.master.TestAssignmentListener | | | org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence | | | org.apache.hadoop.hbase.constraint.TestConstraint | | | org.apache.hadoop.hbase.client.TestScannersFromClientSide2 | | | org.apache.hadoop.hbase.client.TestZKAsyncRegistry | | | org.apache.hadoop.hbase.filter.TestFilterWithScanLimits | | | org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster | | | org.apache.hadoop.hbase.client.TestMultiRespectsLimits | | | org.apache.hadoop.hbase.client.TestAsyncTableNoncedRetry | | | org.apache.hadoop.hbase.mob.compactions.TestPartitionedMobCompactor | | | org.apache.hadoop.hbase.master.balancer.TestFavoredStochasticLoadBalancer | | | org.apache.hadoop.hbase.quotas.TestRegionSizeUse | | | org.apache.hadoop.hbase.client.TestServerBusyException | | | org.apache.hadoop.hbase.coprocessor.TestMasterObserver | | | org.apache.hadoop.hbase.regionserver.TestRegionServerAbort | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService | | | org.apache.hadoop.hbase.client.TestMetaWithReplicas | | | org.apache.hadoop.hbase.client.TestClientTimeouts | | | org.apache.hadoop.hbase.io.asyncfs.TestSaslFanOutOneBlockAsyncDFSOutput | | | org.apache.hadoop.hbase.regionserver.wal.TestLogRollAbort | | | org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster | | | org.apache.hadoop.hbase.ipc.TestRpcClientLeaks | | | org.apache.hadoop.hbase.util.TestHBaseFsckEncryption | | | org.apache.hadoop.hbase.master.TestTableStateManager | | | org.apache.hadoop.hbase.coprocessor.TestWALObserver | | | org.apache.hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes | | | org.apache.hadoop.hbase.master.cleaner.TestReplicationZKNodeCleaner | | | org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures | | | org.apache.hadoop.hbase.master.assignment.TestAssignmentOnRSCrash | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService | | | org.apache.hadoop.hbase.client.TestFromClientSide3 | | | org.apache.hadoop.hbase.regionserver.TestWalAndCompactingMemStoreFlush | | | org.apache.hadoop.hbase.master.TestSplitLogManager | | | org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS | | | org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable | | | org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput | | | org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport | | | org.apache.hadoop.hbase.TestClusterBootOrder | | | org.apache.hadoop.hbase.regionserver.wal.TestAsyncLogRolling | | | org.apache.hadoop.hbase.master.TestRollingRestart | | | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer | | | org.apache.hadoop.hbase.client.TestScannerTimeout | | | org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss | | | org.apache.hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster | | | org.apache.hadoop.hbase.master.TestDistributedLogSplitting | | | org.apache.hadoop.hbase.quotas.TestSpaceQuotas | | | org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded | | | org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders | | | org.apache.hadoop.hbase.master.TestDeadServer | | | org.apache.hadoop.hbase.mob.compactions.TestMobCompactor | | | org.apache.hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | | org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential | | | org.apache.hadoop.hbase.regionserver.TestRegionServerReportForDuty | | | org.apache.hadoop.hbase.master.TestMasterShutdown | | | org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreWithMiniCluster | | | org.apache.hadoop.hbase.security.TestSecureIPC | | | org.apache.hadoop.hbase.regionserver.wal.TestLogRolling | | | org.apache.hadoop.hbase.client.TestAsyncSingleRequestRpcRetryingCaller | | | org.apache.hadoop.hbase.regionserver.throttle.TestCompactionWithThroughputController | | | org.apache.hadoop.hbase.client.TestAvoidCellReferencesIntoShippedBlocks | | | org.apache.hadoop.hbase.client.TestIncrementFromClientSideWithCoprocessor | | | org.apache.hadoop.hbase.client.TestAdmin2 | | | org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush | | | org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster | | | org.apache.hadoop.hbase.mapred.TestTableOutputFormatConnectionExhaust | | | org.apache.hadoop.hbase.client.TestAdmin1 | | | org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL | | | org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat2 | | | org.apache.hadoop.hbase.regionserver.TestScannerWithBulkload | | | org.apache.hadoop.hbase.regionserver.TestJoinedScanners | | | org.apache.hadoop.hbase.regionserver.wal.TestLogRollingNoCluster | | | org.apache.hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController | | | org.apache.hadoop.hbase.regionserver.TestDeleteMobTable | | | org.apache.hadoop.hbase.regionserver.TestCompactingToCellFlatMapMemStore | | | org.apache.hadoop.hbase.master.TestMaster | | | org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedureFromClient | | | org.apache.hadoop.hbase.master.procedure.TestTableDescriptorModificationFromClient | | | org.apache.hadoop.hbase.security.access.TestNamespaceCommands | | | org.apache.hadoop.hbase.mob.TestExpiredMobFileCleaner | | | org.apache.hadoop.hbase.TestAcidGuarantees | | | org.apache.hadoop.hbase.security.access.TestAccessControlFilter | | | org.apache.hadoop.hbase.filter.TestFilterListOrOperatorWithBlkCnt | | | org.apache.hadoop.hbase.filter.TestFuzzyRowAndColumnRangeFilter | | | org.apache.hadoop.hbase.client.TestSnapshotMetadata | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL | | | org.apache.hadoop.hbase.TestNamespace | | | org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor | | | org.apache.hadoop.hbase.client.TestCheckAndMutate | | | org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks | | | org.apache.hadoop.hbase.regionserver.TestCompoundBloomFilter | | | org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes | | | org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoadWithOldClient | | | org.apache.hadoop.hbase.mapreduce.TestSyncTable | | | org.apache.hadoop.hbase.mapreduce.TestHashTable | | | org.apache.hadoop.hbase.mapreduce.TestCopyTable | | | org.apache.hadoop.hbase.quotas.TestSpaceQuotasWithSnapshots | | | org.apache.hadoop.hbase.client.TestReplicaWithCluster | | | org.apache.hadoop.hbase.client.TestEnableTable | | | org.apache.hadoop.hbase.regionserver.TestRecoveredEdits | | | org.apache.hadoop.hbase.master.procedure.TestMasterProcedureSchedulerConcurrency | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString | | | org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions | | | org.apache.hadoop.hbase.TestInfoServers | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsReplication | | | org.apache.hadoop.hbase.client.TestClientOperationInterrupt | | | org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache | | | org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache | | | org.apache.hadoop.hbase.security.access.TestCellACLs | | | org.apache.hadoop.hbase.TestHBaseOnOtherDfsCluster | | | org.apache.hadoop.hbase.client.TestFastFail | | | org.apache.hadoop.hbase.master.TestRestartCluster | | | org.apache.hadoop.hbase.master.procedure.TestProcedureAdmin | | | org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreRegionReports | | | org.apache.hadoop.hbase.security.visibility.TestWithDisabledAuthorization | | | org.apache.hadoop.hbase.client.TestLeaseRenewal | | | org.apache.hadoop.hbase.filter.TestColumnRangeFilter | | | org.apache.hadoop.hbase.snapshot.TestMobRestoreFlushSnapshotFromClient | | | org.apache.hadoop.hbase.client.TestTimestampsFilter | | | org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel | | | org.apache.hadoop.hbase.TestIOFencing | | | org.apache.hadoop.hbase.regionserver.TestHRegion | | | org.apache.hadoop.hbase.regionserver.TestRSKilledWhenInitializing | | | org.apache.hadoop.hbase.master.TestWarmupRegion | | | org.apache.hadoop.hbase.client.TestHCM | | | org.apache.hadoop.hbase.mapreduce.TestTimeRangeMapRed | | | org.apache.hadoop.hbase.mapreduce.TestImportExport | | | org.apache.hadoop.hbase.security.access.TestWithDisabledAuthorization | | | org.apache.hadoop.hbase.TestLocalHBaseCluster | | | org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite | | | org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk | | | org.apache.hadoop.hbase.TestClockWithCluster | | | org.apache.hadoop.hbase.regionserver.TestMultiColumnScanner | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithSLGStack | | | org.apache.hadoop.hbase.security.access.TestAccessController | | | org.apache.hadoop.hbase.client.TestRawAsyncTablePartialScan | | | org.apache.hadoop.hbase.client.TestRawAsyncTableScan | | | org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClient | | | org.apache.hadoop.hbase.mob.TestDefaultMobStoreFlusher | | | org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | | org.apache.hadoop.hbase.regionserver.TestFSErrorsExposed | | | org.apache.hadoop.hbase.quotas.TestQuotaThrottle | | | org.apache.hadoop.hbase.quotas.TestSuperUserQuotaPermissions | | | org.apache.hadoop.hbase.security.access.TestTablePermissions | | | org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas | | | org.apache.hadoop.hbase.client.TestMvccConsistentScanner | | | org.apache.hadoop.hbase.TestHColumnDescriptorDefaultVersions | | | org.apache.hadoop.hbase.regionserver.TestClusterId | | | org.apache.hadoop.hbase.regionserver.TestRegionServerHostname | | | org.apache.hadoop.hbase.security.access.TestScanEarlyTermination | | | org.apache.hadoop.hbase.client.TestTableSnapshotScanner | | | org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient | | | org.apache.hadoop.hbase.client.TestSmallReversedScanner | | | org.apache.hadoop.hbase.client.TestTableFavoredNodes | | | org.apache.hadoop.hbase.client.TestAsyncTableScan | | | org.apache.hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver | | | org.apache.hadoop.hbase.client.TestFromClientSideNoCodec | | | org.apache.hadoop.hbase.client.TestMultiParallel | | | org.apache.hadoop.hbase.client.TestCloneSnapshotFromClientWithRegionReplicas | | | org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient | | | org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient | | | org.apache.hadoop.hbase.regionserver.TestSettingTimeoutOnBlockingPoint | | | org.apache.hadoop.hbase.master.TestRegionPlacement2 | | | org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort | | | org.apache.hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed | | | org.apache.hadoop.hbase.security.access.TestZKPermissionsWatcher | | | org.apache.hadoop.hbase.client.TestBlockEvictionFromClient | | | org.apache.hadoop.hbase.client.TestAsyncTableScanner | | | org.apache.hadoop.hbase.client.TestCloneSnapshotFromClient | | | org.apache.hadoop.hbase.util.TestConnectionCache | | | org.apache.hadoop.hbase.io.hfile.TestHFileBlock | | | org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover | | | org.apache.hadoop.hbase.wal.TestBoundedRegionGroupingStrategy | | | org.apache.hadoop.hbase.wal.TestWALFactory | | | org.apache.hadoop.hbase.regionserver.TestStore | | | org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFilesSplitRecovery | | | org.apache.hadoop.hbase.quotas.TestQuotaAdmin | | | org.apache.hadoop.hbase.client.TestIncrementsFromClientSide | | | org.apache.hadoop.hbase.client.TestMobSnapshotFromClient | | | org.apache.hadoop.hbase.client.TestHTableMultiplexer | | | org.apache.hadoop.hbase.wal.TestFSHLogProvider | | | org.apache.hadoop.hbase.util.TestIdReadWriteLock | | | org.apache.hadoop.hbase.regionserver.TestRegionServerReadRequestMetrics | | | org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedure | | | org.apache.hadoop.hbase.master.procedure.TestModifyColumnFamilyProcedure | | | org.apache.hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure | | | org.apache.hadoop.hbase.client.TestSnapshotFromClientWithRegionReplicas | | | org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd | | | org.apache.hadoop.hbase.regionserver.TestCompactionState | | | org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoad | | | org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod | | | org.apache.hadoop.hbase.mapreduce.TestTableSnapshotInputFormat | | | org.apache.hadoop.hbase.master.assignment.TestSplitTableRegionProcedure | | | org.apache.hadoop.hbase.client.TestAsyncAdminBuilder | | | org.apache.hadoop.hbase.client.TestScannersFromClientSide | | | org.apache.hadoop.hbase.regionserver.wal.TestWALReplayCompressed | | | org.apache.hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay | | | org.apache.hadoop.hbase.replication.TestSerialReplication | | | org.apache.hadoop.hbase.TestPartialResultsFromClientSide | | | org.apache.hadoop.hbase.client.TestSnapshotFromClient | | | org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithAbort | | | org.apache.hadoop.hbase.regionserver.TestAtomicOperation | | | org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas | | | org.apache.hadoop.hbase.master.procedure.TestCreateNamespaceProcedure | | | org.apache.hadoop.hbase.master.procedure.TestModifyNamespaceProcedure | | | org.apache.hadoop.hbase.master.procedure.TestAddColumnFamilyProcedure | | | org.apache.hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure | | | org.apache.hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure | | | org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat | | | org.apache.hadoop.hbase.client.TestResultSizeEstimation | | | org.apache.hadoop.hbase.io.TestFileLink | | | org.apache.hadoop.hbase.tool.TestCanaryTool | | | org.apache.hadoop.hbase.master.TestMetaShutdownHandler | | | org.apache.hadoop.hbase.util.TestFSUtils | | | org.apache.hadoop.hbase.io.encoding.TestBufferedDataBlockEncoder | | | org.apache.hadoop.hbase.regionserver.TestMajorCompaction | | | org.apache.hadoop.hbase.regionserver.TestCompactionInDeadRegionServer | | | org.apache.hadoop.hbase.regionserver.TestScannerRetriableFailure | | | org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery | | | org.apache.hadoop.hbase.master.procedure.TestTruncateTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestCloneSnapshotProcedure | | | org.apache.hadoop.hbase.client.TestMobSnapshotCloneIndependence | | | org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2 | | | org.apache.hadoop.hbase.wal.TestWALSplit | | | org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers | | | org.apache.hadoop.hbase.mapreduce.TestImportTsv | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:757bf37 | | JIRA Issue | HBASE-18432 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12878443/HBASE-18432.HBASE-14070.HLC.001.patch | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 7378ccdf3e61 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | HBASE-14070.HLC / 45bb4f0 | | Default Java | 1.8.0_131 | | findbugs | v3.1.0-RC3 | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/7759/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html | | javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/7759/artifact/patchprocess/diff-javadoc-javadoc-hbase-common.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/7759/artifact/patchprocess/patch-unit-hbase-common.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/7759/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/7759/testReport/ | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/7759/console | | Powered by | Apache Yetus 0.4.0 http://yetus.apache.org | This message was automatically generated. > Prevent clock from getting stuck after update() > ----------------------------------------------- > > Key: HBASE-18432 > URL: https://issues.apache.org/jira/browse/HBASE-18432 > Project: HBase > Issue Type: Sub-task > Reporter: Appy > Assignee: Appy > Attachments: HBASE-18432.HBASE-14070.HLC.001.patch > > > There were a [bunch of > problems|https://issues.apache.org/jira/browse/HBASE-14070?focusedCommentId=16094013&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16094013] > (also copied below) with clock getting stuck after call to update() until > it's own system time caught up. > ---- > PT = physical time, LT = logical time, ST = system time, X = don't care terms > ---- > Core issue: > - Note that in current implementation, we are passing master clock to RS in > open/close region request and RS clock to master in the responses. And they > both update their own time on receiving these request/response. > - On receiving a clock ahead of its own, they update their own clock to its > PT+LT, and keep increasing LT till their own ST catches that PT. > ---- > Proposed solution: > Keep track of skew in clock. And instead of keeping track of physical time, > always compute it by adding system time and skew. > On update(), recalculate skew and validate if it's greater than max_skew. > On toTimestamp(), calculate PT = ST+skew. > ----- > ----- > Issues with current approach: > ---- > Problem 1: Logical time window too small. > RS clock (10, X) > Master clock (20, X) > Master --request-> RS > RS clock (20, X) > While RS's physical java clock (which is backing up physical component of hlc > clock) will still take 10 sec to catch up, we'll keep incrementing logical > component. That means, in worst case, our logical clock window should be big > enough to support all the events that can happen in max skew time. > The problem is, that doesn't seem to be the case. Our logical window is 1M > events (20bits) and max skew time is 30 sec, that results in 33k max write > qps, which is quite low. We can easily see 150k update qps per beefy server > with 1k values. > Even 22 bits won't be enough. We'll need minimum of 23 bits and 20 sec max > skew time to support ~420k max events per second in worst case clock skew. > ---- > Problem 2: Cascading logical time increment. > When more RS are involved say - 3 RS and 1 master. Let's say max skew is 30 > sec. > HLC Clocks (physical time, logical time): X = don't care > RS1: (50, 100k) > Master: (40, X) > RS2: (30, X) > RS3: (20, X) > [RS3's ST behind RS1's by 30 sec.] > RS1 replies to master, sends it's clock (50,X). > Master's clock (50, X). It'll be another 10 sec before it's own physical > clock reaches 50, so HLC's PT will remain 50 for next 10 sec. > Master --> RS2 > RS2's clock = (50, X). > RS2 keeps incrementing LT on writes (since it's own PT is behind) for few > seconds before it replies back to master with (50, X+ few 100k). > Master's clock = (50, X+ few 100k) [Since master's physical clock hasn't > caught up yet, note that it was 10 seconds behind, PT remains 50.]. > Master --> RS3 > RS3's clock (50, X+few 100k) > But RS3's ST is behind RS1's ST by 30 sec, which means it'll keep > incrementing LT for next 30 sec (unless it gets a newer clock from master). > But the problem is, RS3 has much smaller LT window than actual 1M!! > — > Problem 3: Single bad RS clock crashing the cluster: > If a single RS's clock is bad and a bit faster, it'll catch time and keep > pulling master's PT with it. If 'real time' is say 20, max skew time is 10, > and bad RS is at time 29.9, it'll pull master to 29.9 (via next response), > and then any RS less than 19.9, i.e. just 0.1 sec away from real time will > die due to higher than max skew. > This can bring whole clusters down! > — > Problem 4: Time jumps (not a bug, but more of a nuisance) > Say a RS is behind master by 20 sec. On each communication from master, RS > will update its own PT to master's PT, and it'll remain that till RS's ST > catches up. If there are frequent communication from master, ST might never > catch up and RS's PT will actually look like discrete time jumps rather than > continuous time. > For eg. If master communicated with RS at times 30, 40, 50 (RSs corresponding > times are 10, 20, 30), than all events on RS between time [10, 50] will be > timestamped with either 30, 40 or 50. > — -- This message was sent by Atlassian JIRA (v6.4.14#64029)