[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097633#comment-16097633
]
Ashish Singhi commented on HBASE-17442:
---------------------------------------
bq. So I add a patch which more them to hbase-server package first.
Can you raise a jira to move the replication stuff from hbase-server to a new
hbase-replication package.
bq. It is ok to modify public methods when we release a major version 2.0?
If its from public class then we should not if it wasn't deprecated in the
previous major version.
{code}
- public void peerAdded(String id) throws ReplicationException {
- List<ReplicationPeer> listReplicationPeers() throws IOException {
{code}
For current master branch (3.0.0) it should be fine but we cannot remove it
from 2.0 as it was not marked as deprecated in 1.x
Skimmed the patch looks good to me.
> Move most of the replication related classes to hbase-server package
> --------------------------------------------------------------------
>
> Key: HBASE-17442
> URL: https://issues.apache.org/jira/browse/HBASE-17442
> Project: HBase
> Issue Type: Sub-task
> Components: build, Replication
> Affects Versions: 2.0.0
> Reporter: Guanghao Zhang
> Assignee: Guanghao Zhang
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: 0001-hbase-replication-module.patch,
> HBASE-17442.v1.patch, HBASE-17442.v2.patch, HBASE-17442.v2.patch,
> HBASE-17442.v3.patch
>
>
> After the replication requests are routed through master, replication
> implementation details didn't need be exposed to client. We should move most
> of the replication related classes to hbase-server package.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
