[ 
https://issues.apache.org/jira/browse/HBASE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182234#comment-13182234
 ] 

Zhihong Yu commented on HBASE-4224:
-----------------------------------

w.r.t. whether flushAllRegions() should be introduced into HRegionInterface. In 
your patch HBaseAdmin has this method:
{ocde}
private boolean flush(ServerName serverName, List<HRegionInfo> regions)
{ocde}
which decides the scope of flushing by checking regions. I think this check can 
be performed on region server side.

Your argument about javadoc makes sense. We should clearly document the 
functionality of the (single) new method added to HRegionInterface.

bq. But then we'd be masking those errors right?
Please refer to HRegion.bulkLoadHFiles() for example of buffering multiple 
IOE's:
{code}
      if (ioes.size() != 0) {
        LOG.error("There were IO errors when checking if bulk load is ok.  " +
            "throwing exception!");
        throw MultipleIOException.createIOException(ioes);
      }
{code}
                
> Need a flush by regionserver rather than by table option
> --------------------------------------------------------
>
>                 Key: HBASE-4224
>                 URL: https://issues.apache.org/jira/browse/HBASE-4224
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>            Reporter: stack
>            Assignee: Akash Ashok
>         Attachments: HBase-4224-v2.patch, HBase-4224.patch
>
>
> This evening needed to clean out logs on the cluster.  logs are by 
> regionserver.  to let go of logs, we need to have all edits emptied from 
> memory.  only flush is by table or region.  We need to be able to flush the 
> regionserver.  Need to add this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to