[ 
https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103197#comment-16103197
 ] 

Duo Zhang commented on HBASE-18446:
-----------------------------------

OK, we have this

{code:title=RegionObserver.java}
  /**
   * Called before bulkLoadHFile. Users can create a StoreFile instance to
   * access the contents of a HFile.
   *
   * @param ctx the environment provided by the region server
   * @param familyPaths pairs of { CF, HFile path } submitted for bulk load. 
Adding
   * or removing from this list will add or remove HFiles to be bulk loaded.
   */
  default void preBulkLoadHFile(final 
ObserverContext<RegionCoprocessorEnvironment> ctx,
    List<Pair<byte[], String>> familyPaths) throws IOException {}
{code}

[~apurtell] Sir do you have any use cases of this method? I think we can 
provide a {{createStoreFile}} method in the {{Region}} interface to avoid users 
use the implementation class directly. But I do not know how do users use the 
{{StoreFile}} instance. And on 'access the contents of a HFile', this means we 
need to also expose {{StoreFileReader}} to users? Oh no, it is also an 
implementation class...

We need to hurry up...

Thanks.

> Mark StoreFileScanner as IA.Private
> -----------------------------------
>
>                 Key: HBASE-18446
>                 URL: https://issues.apache.org/jira/browse/HBASE-18446
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: Duo Zhang
>             Fix For: 2.0.0, 3.0.0, 2.0.0-alpha-2
>
>
> Do not see any reason why it is marked as IA.LimitedPrivate. It is not 
> referenced in any CPs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to