[ https://issues.apache.org/jira/browse/HBASE-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108305#comment-16108305 ]
Hadoop QA commented on HBASE-18395: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 17s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 13 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m 21s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 7s{color} | {color:green} HBASE-14070.HLC passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 34s{color} | {color:green} HBASE-14070.HLC passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 5s{color} | {color:green} HBASE-14070.HLC passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 13s{color} | {color:green} HBASE-14070.HLC passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 25s{color} | {color:red} hbase-protocol-shaded in HBASE-14070.HLC has 27 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 15s{color} | {color:red} hbase-server in HBASE-14070.HLC has 9 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 46s{color} | {color:green} HBASE-14070.HLC passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 25s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 26 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 40m 46s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 2m 11s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 16s{color} | {color:red} hbase-server generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 35s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 2m 21s{color} | {color:red} hbase-common in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 37s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 23s{color} | {color:green} hbase-protocol in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 5s{color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 86m 37s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 2m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}187m 5s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hbase-server | | | There is an apparent infinite recursive loop in org.apache.hadoop.hbase.master.ServerManager.sendRegionClose(ServerName, HRegionInfo, Long) At ServerManager.java:recursive loop in org.apache.hadoop.hbase.master.ServerManager.sendRegionClose(ServerName, HRegionInfo, Long) At ServerManager.java:[line 897] | | Failed junit tests | hadoop.hbase.TestTimestampType | | Timed out junit tests | org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure | | | org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay | | | org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure | | | org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure | | | org.apache.hadoop.hbase.regionserver.TestRowTooBig | | | org.apache.hadoop.hbase.regionserver.wal.TestAsyncWALReplay | | | org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy | | | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId | | | org.apache.hadoop.hbase.regionserver.wal.TestFSHLog | | | org.apache.hadoop.hbase.regionserver.TestCompaction | | | org.apache.hadoop.hbase.trace.TestHTraceHooks | | | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 | | | org.apache.hadoop.hbase.regionserver.TestRemoveRegionMetrics | | | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries | | | org.apache.hadoop.hbase.backup.TestRemoteBackup | | | org.apache.hadoop.hbase.master.TestAssignmentManagerMetrics | | | org.apache.hadoop.hbase.regionserver.TestTimestampFilterSeekHint | | | org.apache.hadoop.hbase.TestHBaseTestingUtility | | | org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint | | | org.apache.hadoop.hbase.wal.TestWALFiltering | | | org.apache.hadoop.hbase.backup.TestFullBackup | | | org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream | | | org.apache.hadoop.hbase.master.TestGetInfoPort | | | org.apache.hadoop.hbase.TestZooKeeper | | | org.apache.hadoop.hbase.wal.TestWALSplitCompressed | | | org.apache.hadoop.hbase.master.TestAssignmentListener | | | org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence | | | org.apache.hadoop.hbase.filter.TestScanRowPrefix | | | org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster | | | org.apache.hadoop.hbase.regionserver.TestMutateRowsRecovery | | | org.apache.hadoop.hbase.regionserver.TestRegionServerAbort | | | org.apache.hadoop.hbase.quotas.TestRegionSizeUse | | | org.apache.hadoop.hbase.backup.TestBackupDescribe | | | org.apache.hadoop.hbase.io.asyncfs.TestSaslFanOutOneBlockAsyncDFSOutput | | | org.apache.hadoop.hbase.regionserver.wal.TestLogRollAbort | | | org.apache.hadoop.hbase.regionserver.TestCompactSplitThread | | | org.apache.hadoop.hbase.backup.TestRepairAfterFailedDelete | | | org.apache.hadoop.hbase.util.TestHBaseFsckEncryption | | | org.apache.hadoop.hbase.master.TestMasterMetrics | | | org.apache.hadoop.hbase.master.TestTableStateManager | | | org.apache.hadoop.hbase.backup.TestBackupDeleteRestore | | | org.apache.hadoop.hbase.regionserver.TestWalAndCompactingMemStoreFlush | | | org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput | | | org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable | | | org.apache.hadoop.hbase.master.TestSplitLogManager | | | org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS | | | org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport | | | org.apache.hadoop.hbase.master.TestRollingRestart | | | org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss | | | org.apache.hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster | | | org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders | | | org.apache.hadoop.hbase.master.TestDistributedLogSplitting | | | org.apache.hadoop.hbase.TestJMXConnectorServer | | | org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded | | | org.apache.hadoop.hbase.master.TestDeadServer | | | org.apache.hadoop.hbase.backup.TestFullBackupSet | | | org.apache.hadoop.hbase.backup.TestRemoteRestore | | | org.apache.hadoop.hbase.backup.TestIncrementalBackupDeleteTable | | | org.apache.hadoop.hbase.regionserver.TestRegionServerReportForDuty | | | org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential | | | org.apache.hadoop.hbase.master.TestMasterShutdown | | | org.apache.hadoop.hbase.regionserver.wal.TestLogRolling | | | org.apache.hadoop.hbase.backup.TestFullRestore | | | org.apache.hadoop.hbase.regionserver.throttle.TestCompactionWithThroughputController | | | org.apache.hadoop.hbase.backup.TestBackupDelete | | | org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster | | | org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush | | | org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner | | | org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL | | | org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat2 | | | org.apache.hadoop.hbase.regionserver.wal.TestLogRollingNoCluster | | | org.apache.hadoop.hbase.regionserver.TestJoinedScanners | | | org.apache.hadoop.hbase.util.TestFromClientSide3WoUnsafe | | | org.apache.hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController | | | org.apache.hadoop.hbase.regionserver.TestCompactingToCellFlatMapMemStore | | | org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedureFromClient | | | org.apache.hadoop.hbase.master.TestMaster | | | org.apache.hadoop.hbase.filter.TestFuzzyRowAndColumnRangeFilter | | | org.apache.hadoop.hbase.TestGlobalMemStoreSize | | | org.apache.hadoop.hbase.regionserver.TestCompactionWithCoprocessor | | | org.apache.hadoop.hbase.TestNamespace | | | org.apache.hadoop.hbase.backup.TestIncrementalBackupWithFailures | | | org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks | | | org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster | | | org.apache.hadoop.hbase.regionserver.TestCompoundBloomFilter | | | org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoadWithOldClient | | | org.apache.hadoop.hbase.regionserver.TestRecoveredEdits | | | org.apache.hadoop.hbase.quotas.TestSpaceQuotasWithSnapshots | | | org.apache.hadoop.hbase.backup.TestBackupDeleteWithFailures | | | org.apache.hadoop.hbase.master.procedure.TestMasterProcedureSchedulerConcurrency | | | org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions | | | org.apache.hadoop.hbase.filter.TestMultiRowRangeFilter | | | org.apache.hadoop.hbase.backup.TestFullBackupWithFailures | | | org.apache.hadoop.hbase.TestHBaseOnOtherDfsCluster | | | org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache | | | org.apache.hadoop.hbase.util.TestRegionMover | | | org.apache.hadoop.hbase.replication.TestReplicationTableBase | | | org.apache.hadoop.hbase.master.TestRestartCluster | | | org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreRegionReports | | | org.apache.hadoop.hbase.snapshot.TestMobRestoreFlushSnapshotFromClient | | | org.apache.hadoop.hbase.TestIOFencing | | | org.apache.hadoop.hbase.regionserver.TestRSKilledWhenInitializing | | | org.apache.hadoop.hbase.regionserver.TestHRegion | | | org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel | | | org.apache.hadoop.hbase.master.TestWarmupRegion | | | org.apache.hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient | | | org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite | | | org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk | | | org.apache.hadoop.hbase.TestLocalHBaseCluster | | | org.apache.hadoop.hbase.master.procedure.TestMasterProcedureEvents | | | org.apache.hadoop.hbase.regionserver.TestMultiColumnScanner | | | org.apache.hadoop.hbase.backup.TestBackupStatusProgress | | | org.apache.hadoop.hbase.regionserver.TestFSErrorsExposed | | | org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient | | | org.apache.hadoop.hbase.regionserver.TestClusterId | | | org.apache.hadoop.hbase.regionserver.TestRegionServerHostname | | | org.apache.hadoop.hbase.regionserver.TestMobStoreScanner | | | org.apache.hadoop.hbase.backup.TestRestoreBoundaryTests | | | org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles | | | org.apache.hadoop.hbase.fs.TestBlockReorder | | | org.apache.hadoop.hbase.backup.TestBackupBoundaryTests | | | org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction | | | org.apache.hadoop.hbase.regionserver.TestSettingTimeoutOnBlockingPoint | | | org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient | | | org.apache.hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat | | | org.apache.hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed | | | org.apache.hadoop.hbase.io.hfile.TestHFileBlock | | | org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover | | | org.apache.hadoop.hbase.util.TestConnectionCache | | | org.apache.hadoop.hbase.backup.TestBackupRepair | | | org.apache.hadoop.hbase.regionserver.TestStore | | | org.apache.hadoop.hbase.wal.TestBoundedRegionGroupingStrategy | | | org.apache.hadoop.hbase.wal.TestWALFactory | | | org.apache.hadoop.hbase.backup.TestIncrementalBackupWithBulkLoad | | | org.apache.hadoop.hbase.backup.TestBackupMultipleDeletes | | | org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFilesSplitRecovery | | | org.apache.hadoop.hbase.wal.TestFSHLogProvider | | | org.apache.hadoop.hbase.util.TestIdReadWriteLock | | | org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd | | | org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedure | | | org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoad | | | org.apache.hadoop.hbase.replication.regionserver.TestReplicationSourceManagerZkImpl | | | org.apache.hadoop.hbase.replication.TestMasterReplication | | | org.apache.hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay | | | org.apache.hadoop.hbase.regionserver.wal.TestWALReplayCompressed | | | org.apache.hadoop.hbase.replication.TestReplicationSource | | | org.apache.hadoop.hbase.master.procedure.TestFastFailOnProcedureNotRegistered | | | org.apache.hadoop.hbase.regionserver.TestAtomicOperation | | | org.apache.hadoop.hbase.backup.TestFullBackupSetRestoreSet | | | org.apache.hadoop.hbase.tool.TestCanaryTool | | | org.apache.hadoop.hbase.io.TestFileLink | | | org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas | | | org.apache.hadoop.hbase.master.procedure.TestAddColumnFamilyProcedure | | | org.apache.hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure | | | org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat | | | org.apache.hadoop.hbase.master.TestMetaShutdownHandler | | | org.apache.hadoop.hbase.regionserver.TestMajorCompaction | | | org.apache.hadoop.hbase.regionserver.TestCompactionInDeadRegionServer | | | org.apache.hadoop.hbase.util.TestFSUtils | | | org.apache.hadoop.hbase.backup.TestBackupShowHistory | | | org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers | | | org.apache.hadoop.hbase.master.procedure.TestCloneSnapshotProcedure | | | org.apache.hadoop.hbase.master.procedure.TestTruncateTableProcedure | | | org.apache.hadoop.hbase.wal.TestWALSplit | | | org.apache.hadoop.hbase.backup.TestIncrementalBackup | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:757bf37 | | JIRA Issue | HBASE-18395 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12879741/HBASE-18395.HBASE-14070.HLC.005.patch | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc | | uname | Linux f676b9d5aaa8 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | HBASE-14070.HLC / 45bb4f0 | | Default Java | 1.8.0_131 | | findbugs | v3.1.0-RC3 | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/7859/artifact/patchprocess/branch-findbugs-hbase-protocol-shaded-warnings.html | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/7859/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html | | whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/7859/artifact/patchprocess/whitespace-eol.txt | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/7859/artifact/patchprocess/new-findbugs-hbase-server.html | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/7859/artifact/patchprocess/patch-unit-hbase-common.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/7859/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/7859/testReport/ | | modules | C: hbase-common hbase-protocol-shaded hbase-protocol hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/7859/console | | Powered by | Apache Yetus 0.4.0 http://yetus.apache.org | This message was automatically generated. > Update clock on region open and close > ------------------------------------- > > Key: HBASE-18395 > URL: https://issues.apache.org/jira/browse/HBASE-18395 > Project: HBase > Issue Type: Sub-task > Reporter: Amit Patel > Assignee: Amit Patel > Priority: Minor > Attachments: HBASE-18395.HBASE-14070.HLC.001.patch, > HBASE-18395.HBASE-14070.HLC.002.patch, HBASE-18395.HBASE-14070.HLC.003.patch, > HBASE-18395.HBASE-14070.HLC.004.patch, HBASE-18395.HBASE-14070.HLC.005.patch > > > This task covers the patch for updating the clock on region opening and > closing. > The patch would include the following: > * Addition of a new protobuf message type that contains a field for a > timestamp > * Setting of timestamp field in building region open/close request and > response messages > * Updating the clock upon receiving message > The patch for this task will be going against the > [HBASE-14070.HLC|https://git-wip-us.apache.org/repos/asf?p=hbase.git;a=shortlog;h=refs/heads/HBASE-14070.HLC] > branch with the intent that it would be added as a commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)