[ 
https://issues.apache.org/jira/browse/HBASE-18142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110078#comment-16110078
 ] 

Chia-Ping Tsai commented on HBASE-18142:
----------------------------------------

{code}
-        d.addColumns(family, qualifier, timestamp)
+        d.addColumn(family, qualifier, timestamp)
{code}
The method "_createdelete_internal" is also used by deleteall.rb. If the 
"d.addColumns" is replaced by " d.addColumn", the deleteall.rb will be broken. 
As I see it, the method which need to be adjusted is "_delete_internal".
{code}
    # Delete a cell
    def _delete_internal(row, column,
                         timestamp = 
org.apache.hadoop.hbase.HConstants::LATEST_TIMESTAMP, args = {})
      _deleteall_internal(row, column, timestamp, args)
    end
{code}

Would you please add the tests for "delete" and "deleteall" ?

> Deletion of a cell deletes the previous versions too
> ----------------------------------------------------
>
>                 Key: HBASE-18142
>                 URL: https://issues.apache.org/jira/browse/HBASE-18142
>             Project: HBase
>          Issue Type: Bug
>          Components: API
>    Affects Versions: 3.0.0
>            Reporter: Karthick
>            Assignee: ChunHao
>              Labels: beginner
>             Fix For: 3.0.0
>
>         Attachments: HBASE-18142.master.v0.patch
>
>
> When I tried to delete a cell using it's timestamp in the Hbase Shell, the 
> previous versions of the same cell also got deleted. But when I tried the 
> same using the Java API, then the previous versions are not deleted and I can 
> retrive the previous values.
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Delete.java
> see this file to fix the issue. This method (public Delete addColumns(final 
> byte [] family, final byte [] qualifier, final long timestamp)) only deletes 
> the current version of the cell. The previous versions are not deleted.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to