[ 
https://issues.apache.org/jira/browse/HBASE-18485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110670#comment-16110670
 ] 

Ted Yu commented on HBASE-18485:
--------------------------------

{code}
+    Thread prefetcher = new Thread(prefetchRunnable);
{code}
prefetcher should be background thread.
{code}
+  private long resultSize2CacheSize(long maxResultSize) {
+    // * 2 if possible
{code}
What's the rationale behind the doubling ?
{code}
+          throw new InterruptedIOException();
{code}
Better add some message to the exception.



> Performance issue: ClientAsyncPrefetchScanner is slower than 
> ClientSimpleScanner
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-18485
>                 URL: https://issues.apache.org/jira/browse/HBASE-18485
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>         Attachments: HBASE-18485-v1.patch, HBASE-18485-v2.patch
>
>
> Copied the test result from HBASE-17994.
> {code}
> ./bin/hbase org.apache.hadoop.hbase.PerformanceEvaluation --rows=100000 
> --nomapred scan 1
> ./bin/hbase org.apache.hadoop.hbase.PerformanceEvaluation --rows=100000 
> --nomapred --asyncPrefetch=True scan 1
> {code}
> Mean latency.
> || ||Test1|| Test2 || Test3 || Test4|| Test5||
> |scan| 12.21 | 14.32 | 13.25 | 13.07 | 11.83 |
> |scan with prefetch=True | 37.36 | 37.88 | 37.56 | 37.66 | 38.28 |



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to