[ 
https://issues.apache.org/jira/browse/HBASE-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111069#comment-16111069
 ] 

Sean Busbey commented on HBASE-18304:
-------------------------------------

Thanks for digging into this [~tamaas]. I like the incremental approach of 
making sure we don't get new mismatched dependencies and then working through 
the list of current excludes.

Rough back of the envelope, I expect the current list to go like this:

bq. 1042                            
<exclude>com.google.protobuf:protobuf-java</exclude>

This is going to be a nightmare due to our purposeful handling of multiple 
versions. But maybe I'm misunderstanding it, since shouldn't our internal use 
of protobuf 3 be masked since we relocate it in third-party-deps?

bq. 1043                            <exclude>org.slf4j:slf4j-log4j12</exclude>

This one should be easy to just set to latest.

bq. 1044                            <exclude>com.google.guava:guava</exclude>

Maybe solved for us by our move to third-party-deps? Shouldn't only Hadoop's 
show up? or is the conflict in spark or some such? (questions for the eventual 
follow-on JIRA)

{quote}
1045                        
<exclude>com.thoughtworks.paranamer:paranamer</exclude>
1046                        <exclude>commons-net:commons-net</exclude>
1047                        <exclude>net.java.dev.jets3t:jets3t</exclude>
{quote}

These should go okay.

{quote}
1048                        <exclude>org.scala-lang:scala-library</exclude>
1049                        <exclude>org.scala-lang:scala-reflect</exclude>
{quote}

These are probably just an error in our spark module. Best not to try to 
address it until we close out HBASE-16179

bq. 1050                            <exclude>io.netty:netty</exclude>

I think also solved by our move to third-party-deps on HBASE-18271

> Start enforcing upperbounds on dependencies
> -------------------------------------------
>
>                 Key: HBASE-18304
>                 URL: https://issues.apache.org/jira/browse/HBASE-18304
>             Project: HBase
>          Issue Type: Task
>          Components: build, dependencies
>    Affects Versions: 2.0.0
>            Reporter: Sean Busbey
>            Assignee: Tamas Penzes
>              Labels: beginner
>             Fix For: 2.0.0
>
>         Attachments: HBASE-18304.master.001.patch, 
> HBASE-18304.master.002.patch, HBASE-18304.master.002.patch
>
>
> would be nice to get this going before our next major version.
> http://maven.apache.org/enforcer/enforcer-rules/requireUpperBoundDeps.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to