[ 
https://issues.apache.org/jira/browse/HBASE-18398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119555#comment-16119555
 ] 

Ashu Pachauri commented on HBASE-18398:
---------------------------------------

[~anoop.hbase] 
bq. Store is exposed to CPs and this method make no sense for CPs
Yeah, that makes sense, I'll remove it from the Store interface.

[~ram_krish]
bq. may be even the Region level method need not be exposed if already the 
closeRegionOperation(Operation) was not exposed earlier.
I think the closeRegionOperation(Operation) makes sense at the Region level. In 
fact, I would argue that starRegionOperation() and closeRegionOperation() 
without arguments don't make much sense. The Operation enum is defined in the 
Region interface, it should expose a method to start and close specific 
operations.

> Snapshot operation fails with FileNotFoundException
> ---------------------------------------------------
>
>                 Key: HBASE-18398
>                 URL: https://issues.apache.org/jira/browse/HBASE-18398
>             Project: HBase
>          Issue Type: Sub-task
>          Components: snapshots
>            Reporter: Ashu Pachauri
>            Assignee: Ashu Pachauri
>             Fix For: 1.3.2
>
>         Attachments: HBASE-18398.branch-1.3.001.patch, 
> HBASE-18398.branch-1.3.002.patch, HBASE-18398.master.001.patch, 
> HBASE-18398.master.002.patch, HBASE-18398.master.003.patch
>
>
> Failing to take snapshot due to FileNotFoundException
>     * FlushSnapshotSubprocedure.RegionSnapshotTask takes a region level read 
> lock
>     * Call to HRegion#addRegionToSnapshot.
>     * Call to SnapshotManifest#addRegion. This gets the current list of store 
> files.
>     * RACE → File is marked as compacted away and HFileArchiver moves the 
> file to archive under store level lock.
>     * SnapshotManifest#addRegion visits the stale list of store files one by 
> one. It does a file.getStatus() call to get length of each file. Since the 
> file object still points to the original file, file.getStatus() fails with 
> FileNotFoundException.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to