Chia-Ping Tsai created HBASE-18546:
--------------------------------------

             Summary: Append/Increment a cell with custom timestamp
                 Key: HBASE-18546
                 URL: https://issues.apache.org/jira/browse/HBASE-18546
             Project: HBase
          Issue Type: Bug
            Reporter: Chia-Ping Tsai
            Assignee: Chia-Ping Tsai


We don't pass the custom timestamp for Increment, and the increment's timestamp 
always be rewrite. Hence, user can't increment a cell with custom timestamp.
{code:title=ProtobufUtil.java}
      if (values != null && values.size() > 0) {
        for (Cell cell: values) {
          valueBuilder.clear();
          valueBuilder.setQualifier(UnsafeByteOperations.unsafeWrap(
              cell.getQualifierArray(), cell.getQualifierOffset(), 
cell.getQualifierLength()));
          valueBuilder.setValue(UnsafeByteOperations.unsafeWrap(
              cell.getValueArray(), cell.getValueOffset(), 
cell.getValueLength()));
          if (cell.getTagsLength() > 0) {
            
valueBuilder.setTags(UnsafeByteOperations.unsafeWrap(cell.getTagsArray(),
                cell.getTagsOffset(), cell.getTagsLength()));
          }
          columnBuilder.addQualifierValue(valueBuilder.build());
        }
      }
{code}
In contrast to Increment, user can append the cell with custom timestamp. It 
would be better that make their behavior consistent. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to