[ 
https://issues.apache.org/jira/browse/HBASE-18484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121793#comment-16121793
 ] 

Hadoop QA commented on HBASE-18484:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
37m 51s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}127m 
46s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
19s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}185m 11s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18484 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12881196/HBASE-18484.v1.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux fd87c684c7e7 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 6246523 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8012/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8012/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> VerifyRep by snapshot  does not work when Yarn / SourceHBase / PeerHBase 
> located in three different HDFS clusters
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-18484
>                 URL: https://issues.apache.org/jira/browse/HBASE-18484
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 2.0.0-alpha-1
>            Reporter: Zheng Hu
>            Assignee: Zheng Hu
>         Attachments: HBASE-18484.v1.patch
>
>
> As HBASE-16466 commented. 
> Seems like that when source hbase cluster / peer hbase cluster / yarn cluster 
> locate in three different HDFS cluster , it has one problem.
> when restoring the snapshot into tmpdir , we need to create region by 
> following code (HRegion#createHRegion)
> {code}
> public static HRegion createHRegion(final HRegionInfo info, final Path 
> rootDir,
>         final Configuration conf, final TableDescriptor hTableDescriptor,
>         final WAL wal, final boolean initialize)
>   throws IOException {
>     LOG.info("creating HRegion " + info.getTable().getNameAsString()
>         + " HTD == " + hTableDescriptor + " RootDir = " + rootDir +
>         " Table name == " + info.getTable().getNameAsString());
>     FileSystem fs = FileSystem.get(conf);                                  
> <-------------------  Here our code use  fs.defaultFs configuration to create 
> region.
>     Path tableDir = FSUtils.getTableDir(rootDir, info.getTable());
>     HRegionFileSystem.createRegionOnFileSystem(conf, fs, tableDir, info);
>     HRegion region = HRegion.newHRegion(tableDir, wal, fs, conf, info, 
> hTableDescriptor, null);
>     if (initialize) region.initialize(null);
>     return region;
>   }
> {code}
> When source cluster & peer cluster locate in two difference file systems , 
> then their fs.defaultFs should be difference, so at least one cluster will 
> fail when restore snapshot into tmpdir . after I added the following fix, it 
> works fine for me.
> {code}
> -FileSystem fs = FileSystem.get(conf);  
> +FileSystem fs = rootDir.getFileSystem(conf);
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to