[
https://issues.apache.org/jira/browse/HBASE-18483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125265#comment-16125265
]
Hao Chan commented on HBASE-18483:
----------------------------------
I found in TestProtoBufRpc.java line 135 that somehow RemoteException should be
caught and thrown as ServiceException. Not sure if this could be an evidence of
real case.
BTW, since I've move the test into TestHCM, do I still need to make that
trivial change in hbase-server?
> The RpcRetryingCaller#translateException doesn't handle RemoteException
> -----------------------------------------------------------------------
>
> Key: HBASE-18483
> URL: https://issues.apache.org/jira/browse/HBASE-18483
> Project: HBase
> Issue Type: Bug
> Affects Versions: 1.3.1, 1.2.6
> Reporter: Chia-Ping Tsai
> Assignee: Hao Chan
> Priority: Minor
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18483.branch-1.3.v0.patch
>
>
> {code}
> if (t instanceof ServiceException) {
> ServiceException se = (ServiceException)t;
> Throwable cause = se.getCause();
> if (cause != null) {
> if (cause instanceof DoNotRetryIOException) {
> throw (DoNotRetryIOException)cause;
> } else if (cause instanceof NeedUnmanagedConnectionException) {
> throw new DoNotRetryIOException(cause);
> }
> }
> // Don't let ServiceException out; its rpc specific.
> t = cause;
> // t could be a RemoteException so go aaround again.
> translateException(t); // here
> } else if (t instanceof DoNotRetryIOException) {
> throw (DoNotRetryIOException)t;
> } else if (t instanceof NeedUnmanagedConnectionException) {
> throw new DoNotRetryIOException(t);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
