[
https://issues.apache.org/jira/browse/HBASE-18587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125966#comment-16125966
]
Zach York commented on HBASE-18587:
-----------------------------------
bq. The ut "testFileIOEngineHandlesZeroLengthInput" is good, but why do we need
the other changes of TestFileIOEngine?
The changes are needed to TestFileIOEngine because the test will randomly fail
in certain conditions:
len = 0 and offset 0; it will fail for
https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
will pass in -1 for offset which is invalid.
len = 0 and i = 13; it will try to specify an offset of the totalCapacity which
is not allowed.
> Fix Flaky TestFileIOEngine
> --------------------------
>
> Key: HBASE-18587
> URL: https://issues.apache.org/jira/browse/HBASE-18587
> Project: HBase
> Issue Type: Bug
> Components: BucketCache, test
> Reporter: Zach York
> Assignee: Zach York
> Attachments: HBASE-18587.branch-1.001.patch,
> HBASE-18587.master.001.patch, HBASE-18587.master.001.patch
>
>
> As a part of HBASE-18533, the Jenkins report said that TestFileIOEngine
> failed. I investigated and noticed that there are two cases where this test
> is flaky:
> len = 0 and offset 0; it will fail for
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java#L198
> will pass in -1 for offset which is invalid.
> len = 0 and i = 13; it will try to specify an offset of the totalCapacity
> which is not allowed.
>
> This patch fixes this test.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
