[ 
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129005#comment-16129005
 ] 

stack commented on HBASE-17614:
-------------------------------

Should hbase-backup be dependent on hbase-protocol-shaded rather than 
hbase-protocol (it is using internals, not coprocessor endpoints):

                
<additionalProtoPathElement>${basedir}/../hbase-protocol/src/main/protobuf</additionalProtoPathElement>

Related, does this new module need this dependency:

132         <dependency>
133           <groupId>org.apache.hbase</groupId>
134           <artifactId>hbase-protocol</artifactId>
135         </dependency>


Can we purge this:

166         <dependency>
167           <groupId>com.google.protobuf</groupId>
168           <artifactId>protobuf-java</artifactId>
169         </dependency>

.... and depend on the internal protobuf at hbase-shaded-protobuf... from 
thirdparty.

Otherwise looking good... Failures related? We seem to fail alot and then the 
rerun passes. Infra?

> Move Backup/Restore into separate module 
> -----------------------------------------
>
>                 Key: HBASE-17614
>                 URL: https://issues.apache.org/jira/browse/HBASE-17614
>             Project: HBase
>          Issue Type: Task
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>            Priority: Blocker
>              Labels: backup
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17614-v1.patch
>
>
> Move all the backup code into separate hbase-backup module.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to