[
https://issues.apache.org/jira/browse/HBASE-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184220#comment-13184220
]
Hadoop QA commented on HBASE-3565:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12510132/HBASE-3565.trunk.v1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated -147 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 78 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplicationPeer
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/729//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/729//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/729//console
This message is automatically generated.
> Add a metric to keep track of slow HLog appends
> -----------------------------------------------
>
> Key: HBASE-3565
> URL: https://issues.apache.org/jira/browse/HBASE-3565
> Project: HBase
> Issue Type: Improvement
> Components: metrics, regionserver
> Reporter: Benoit Sigoure
> Assignee: Mubarak Seyed
> Labels: monitoring
> Fix For: 0.94.0
>
> Attachments: HBASE-3565.trunk.v1.patch
>
>
> Whenever an edit takes too long to be written to an HLog, HBase logs a
> warning such as this one:
> {code}
> 2011-02-23 20:03:14,703 WARN org.apache.hadoop.hbase.regionserver.wal.HLog:
> IPC Server handler 21 on 60020 took 15065ms appending an edit to hlog;
> editcount=126050
> {code}
> I would like to have a counter incremented each time this happens and this
> counter exposed via the metrics stuff in HBase so I can collect it in my
> monitoring system.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
