[ https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133696#comment-16133696 ]
Appy commented on HBASE-17442: ------------------------------ The only two methods (peerAdded and listReplicationPeers) this patch is deleting were marked @VisibleForTesting listValidReplicationPeers() was added as private in HBASE-13057, made public + visibleForTesting in HBASE-14866, then renamed to listReplicationPeers later peerAdded() was added as visibleForTesting in HBASE-15507. So i think it's fine to commit this patch. What say [~zghaobac] [~busbey] [~stack]? > Move most of the replication related classes to hbase-server package > -------------------------------------------------------------------- > > Key: HBASE-17442 > URL: https://issues.apache.org/jira/browse/HBASE-17442 > Project: HBase > Issue Type: Sub-task > Components: build, Replication > Affects Versions: 2.0.0 > Reporter: Guanghao Zhang > Assignee: Guanghao Zhang > Priority: Critical > Fix For: 2.0.0-alpha-3 > > Attachments: 0001-hbase-replication-module.patch, > HBASE-17442.v1.patch, HBASE-17442.v2.patch, HBASE-17442.v2.patch, > HBASE-17442.v3.patch > > > After the replication requests are routed through master, replication > implementation details didn't need be exposed to client. We should move most > of the replication related classes to hbase-server package. -- This message was sent by Atlassian JIRA (v6.4.14#64029)