[ https://issues.apache.org/jira/browse/HBASE-18628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135507#comment-16135507 ]
Hadoop QA commented on HBASE-18628: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 10s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 50s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 56s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 19s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 13s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 37m 59s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 89m 15s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 31s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}147m 7s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Timed out junit tests | org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure | | | org.apache.hadoop.hbase.regionserver.TestRowTooBig | | | org.apache.hadoop.hbase.regionserver.TestSplitLogWorker | | | org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy | | | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId | | | org.apache.hadoop.hbase.regionserver.wal.TestFSHLog | | | org.apache.hadoop.hbase.regionserver.TestCompaction | | | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 | | | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries | | | org.apache.hadoop.hbase.backup.TestRemoteBackup | | | org.apache.hadoop.hbase.regionserver.TestTimestampFilterSeekHint | | | org.apache.hadoop.hbase.TestHBaseTestingUtility | | | org.apache.hadoop.hbase.wal.TestWALFiltering | | | org.apache.hadoop.hbase.backup.TestFullBackup | | | org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream | | | org.apache.hadoop.hbase.master.TestGetInfoPort | | | org.apache.hadoop.hbase.TestZooKeeper | | | org.apache.hadoop.hbase.wal.TestWALSplitCompressed | | | org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence | | | org.apache.hadoop.hbase.regionserver.TestColumnSeeking | | | org.apache.hadoop.hbase.regionserver.TestRegionServerAbort | | | org.apache.hadoop.hbase.quotas.TestRegionSizeUse | | | org.apache.hadoop.hbase.backup.TestBackupDescribe | | | org.apache.hadoop.hbase.io.asyncfs.TestSaslFanOutOneBlockAsyncDFSOutput | | | org.apache.hadoop.hbase.regionserver.wal.TestLogRollAbort | | | org.apache.hadoop.hbase.backup.TestRepairAfterFailedDelete | | | org.apache.hadoop.hbase.util.TestHBaseFsckEncryption | | | org.apache.hadoop.hbase.ipc.TestRpcClientLeaks | | | org.apache.hadoop.hbase.master.TestTableStateManager | | | org.apache.hadoop.hbase.backup.TestBackupDeleteRestore | | | org.apache.hadoop.hbase.master.assignment.TestAssignmentOnRSCrash | | | org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures | | | org.apache.hadoop.hbase.regionserver.TestWalAndCompactingMemStoreFlush | | | org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput | | | org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable | | | org.apache.hadoop.hbase.master.TestSplitLogManager | | | org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS | | | org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport | | | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer | | | org.apache.hadoop.hbase.master.TestRollingRestart | | | org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss | | | org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders | | | org.apache.hadoop.hbase.TestJMXConnectorServer | | | org.apache.hadoop.hbase.wal.TestSecureWAL | | | org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded | | | org.apache.hadoop.hbase.master.TestDeadServer | | | org.apache.hadoop.hbase.backup.TestFullBackupSet | | | org.apache.hadoop.hbase.backup.TestRemoteRestore | | | org.apache.hadoop.hbase.backup.TestIncrementalBackupDeleteTable | | | org.apache.hadoop.hbase.regionserver.TestRegionServerReportForDuty | | | org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential | | | org.apache.hadoop.hbase.master.TestMasterShutdown | | | org.apache.hadoop.hbase.regionserver.wal.TestLogRolling | | | org.apache.hadoop.hbase.backup.TestFullRestore | | | org.apache.hadoop.hbase.regionserver.throttle.TestCompactionWithThroughputController | | | org.apache.hadoop.hbase.backup.TestBackupDelete | | | org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush | | | org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner | | | org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL | | | org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat2 | | | org.apache.hadoop.hbase.regionserver.wal.TestLogRollingNoCluster | | | org.apache.hadoop.hbase.regionserver.TestJoinedScanners | | | org.apache.hadoop.hbase.regionserver.wal.TestAsyncFSWAL | | | org.apache.hadoop.hbase.backup.TestIncrementalBackupMergeWithFailures | | | org.apache.hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController | | | org.apache.hadoop.hbase.regionserver.TestCompactingToCellFlatMapMemStore | | | org.apache.hadoop.hbase.mob.TestExpiredMobFileCleaner | | | org.apache.hadoop.hbase.TestAcidGuarantees | | | org.apache.hadoop.hbase.TestGlobalMemStoreSize | | | org.apache.hadoop.hbase.regionserver.TestCompactionWithCoprocessor | | | org.apache.hadoop.hbase.master.assignment.TestRegionStates | | | org.apache.hadoop.hbase.backup.TestIncrementalBackupWithFailures | | | org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks | | | org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster | | | org.apache.hadoop.hbase.regionserver.TestCompoundBloomFilter | | | org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoadWithOldClient | | | org.apache.hadoop.hbase.regionserver.TestRecoveredEdits | | | org.apache.hadoop.hbase.backup.TestBackupDeleteWithFailures | | | org.apache.hadoop.hbase.master.procedure.TestMasterProcedureSchedulerConcurrency | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString | | | org.apache.hadoop.hbase.backup.TestFullBackupWithFailures | | | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsReplication | | | org.apache.hadoop.hbase.TestHBaseOnOtherDfsCluster | | | org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache | | | org.apache.hadoop.hbase.replication.TestReplicationTableBase | | | org.apache.hadoop.hbase.master.TestRestartCluster | | | org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreRegionReports | | | org.apache.hadoop.hbase.TestIOFencing | | | org.apache.hadoop.hbase.regionserver.TestRSKilledWhenInitializing | | | org.apache.hadoop.hbase.regionserver.TestHRegion | | | org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel | | | org.apache.hadoop.hbase.master.balancer.TestRegionsOnMasterOptions | | | org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite | | | org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk | | | org.apache.hadoop.hbase.TestLocalHBaseCluster | | | org.apache.hadoop.hbase.regionserver.TestMultiColumnScanner | | | org.apache.hadoop.hbase.backup.TestBackupStatusProgress | | | org.apache.hadoop.hbase.regionserver.TestClusterId | | | org.apache.hadoop.hbase.regionserver.TestRegionServerHostname | | | org.apache.hadoop.hbase.backup.TestRestoreBoundaryTests | | | org.apache.hadoop.hbase.fs.TestBlockReorder | | | org.apache.hadoop.hbase.backup.TestBackupBoundaryTests | | | org.apache.hadoop.hbase.regionserver.TestHRegionReplayEvents | | | org.apache.hadoop.hbase.replication.TestMultiSlaveReplication | | | org.apache.hadoop.hbase.io.hfile.TestHFileBlock | | | org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover | | | org.apache.hadoop.hbase.util.TestConnectionCache | | | org.apache.hadoop.hbase.backup.TestBackupRepair | | | org.apache.hadoop.hbase.regionserver.TestStore | | | org.apache.hadoop.hbase.wal.TestBoundedRegionGroupingStrategy | | | org.apache.hadoop.hbase.wal.TestWALFactory | | | org.apache.hadoop.hbase.backup.TestIncrementalBackupWithBulkLoad | | | org.apache.hadoop.hbase.backup.TestBackupMultipleDeletes | | | org.apache.hadoop.hbase.regionserver.TestParallelPut | | | org.apache.hadoop.hbase.wal.TestFSHLogProvider | | | org.apache.hadoop.hbase.util.TestIdReadWriteLock | | | org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoad | | | org.apache.hadoop.hbase.mapreduce.TestTableSnapshotInputFormat | | | org.apache.hadoop.hbase.replication.regionserver.TestReplicationSourceManagerZkImpl | | | org.apache.hadoop.hbase.replication.TestMasterReplication | | | org.apache.hadoop.hbase.replication.TestReplicationSource | | | org.apache.hadoop.hbase.regionserver.TestAtomicOperation | | | org.apache.hadoop.hbase.backup.TestFullBackupSetRestoreSet | | | org.apache.hadoop.hbase.tool.TestCanaryTool | | | org.apache.hadoop.hbase.io.TestFileLink | | | org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat | | | org.apache.hadoop.hbase.io.encoding.TestBufferedDataBlockEncoder | | | org.apache.hadoop.hbase.regionserver.TestMajorCompaction | | | org.apache.hadoop.hbase.regionserver.TestCompactionArchiveIOException | | | org.apache.hadoop.hbase.util.TestFSUtils | | | org.apache.hadoop.hbase.backup.TestBackupShowHistory | | | org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers | | | org.apache.hadoop.hbase.wal.TestWALSplit | | | org.apache.hadoop.hbase.backup.TestIncrementalBackup | | | org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2 | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 | | JIRA Issue | HBASE-18628 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12882890/HBASE-18628.v4.patch | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 1c2574b3a64a 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 820ee91 | | Default Java | 1.8.0_144 | | findbugs | v3.1.0-RC3 | | whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/8197/artifact/patchprocess/whitespace-eol.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/8197/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/8197/testReport/ | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/8197/console | | Powered by | Apache Yetus 0.4.0 http://yetus.apache.org | This message was automatically generated. > ZKPermissionWatcher blocks all ZK notifications > ----------------------------------------------- > > Key: HBASE-18628 > URL: https://issues.apache.org/jira/browse/HBASE-18628 > Project: HBase > Issue Type: Bug > Components: regionserver > Reporter: Mike Drob > Assignee: Mike Drob > Priority: Critical > Fix For: 3.0.0, 2.0.0-alpha-3 > > Attachments: HBASE-18628.patch, HBASE-18628.v2.patch, > HBASE-18628.v3.patch, HBASE-18628.v4.patch, jstack > > > Buckle up folks, we're going for a ride here. I've seeing this on a branch-2 > based build, but I think the problem will affect branch-1 as well. I'm not > able to easily reproduce the issue, but it will usually come up within an > hour on a given cluster that I have, at which point the problem persists > until an RS restart. I've been seeing the problem and paying attention for > maybe two months, but I suspect it's been happening much longer than that. > h3. Problem > When running in a secure cluster, sometimes the ZK EventThread will get stuck > on a permissions update and not be able to process new notifications. This > happens to also block flush and snapshot, which is how we found it. > h3. Analysis > The main smoking gun is seeing this in repeated jstacks: > {noformat} > "main-EventThread" #43 daemon prio=5 os_prio=0 tid=0x00007f0b92644000 > nid=0x6e69 waiting on condition [0x00007f0b6730f000] > java.lang.Thread.State: TIMED_WAITING (sleeping) > at java.lang.Thread.sleep(Native Method) > at > org.apache.hadoop.hbase.security.access.ZKPermissionWatcher.nodeChildrenChanged(ZKPermissionWatcher.java:191) > at > org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.process(ZooKeeperWatcher.java:503) > at > org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:522) > at > org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:498) > {noformat} > That sleep is a 20ms sleep in an {{AtomicReference.compareAndSet}} loop - but > it never gets past the condition. > {code} > while (!nodes.compareAndSet(null, nodeList)) { > try { > Thread.sleep(20); > } catch (InterruptedException e) { > LOG.warn("Interrupted while setting node list", e); > Thread.currentThread().interrupt(); > } > } > {code} > The warning never shows up in the logs, it just keeps looping and looping. > The last relevant line from the watcher in logs is: > {noformat} > 2017-08-17 21:25:12,379 DEBUG > org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher: > regionserver:22101-0x15df38884c80024, quorum=zk1:2181,zk2:2181,zk3:2181, > baseZNode=/hbase Received ZooKeeper Event, type=NodeChildrenChanged, > state=SyncConnected, path=/hbase/acl > {noformat} > Which makes sense, because the code snippet is from permission watcher's > {{nodeChildrenChanged}} handler. > The separate thread introduced in HBASE-14370 is present, but not doing > anything. And this event hasn't gotten to the part where it splits off into a > thread: > {noformat} > "zk-permission-watcher4-thread-1" #160 daemon prio=5 os_prio=0 > tid=0x0000000001750800 nid=0x6fd9 waiting on condition [0x00007f0b5dce5000] > java.lang.Thread.State: WAITING (parking) > at sun.misc.Unsafe.park(Native Method) > - parking to wait for <0x00000007436ecea0> (a > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) > at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) > at > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039) > at > java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442) > at > java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) > {noformat} > h3. Solutions > There's a few approaches we can take to fix this, I think they are all > complimentary. It might be useful to file subtasks or new issues for some of > the solutions if they are longer term. > # Move flush and snapshot to ProcedureV2. This makes my proximate problem go > away, but it's only relevant to branch-2 and master, and doesn't fix anything > on branch-1. Also, Permissions updates would still get stuck, preventing > future permissions updates. I think this is important long term for the > robustness of the system, but not a viable short term fix. > # Add an Executor to ZookeeperWatcher and launch threads from there. Maybe > we'd want to pull the Executor out of ZKPW, but that's not strictly necessary > and can be optimized later -- if we're already threading, then adding another > layer isn't a huge cost. > # Figure out the race condition or logic problem that causes {{nodes}} to be > non-null above. I've tried looking at this and visual inspection isn't > getting me anywhere. -- This message was sent by Atlassian JIRA (v6.4.14#64029)