[ 
https://issues.apache.org/jira/browse/HBASE-18490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136456#comment-16136456
 ] 

huaxiang sun commented on HBASE-18490:
--------------------------------------

Hi [~ram_krish], the logic when newReplicacount is less than the old Count is 
needed since it is going to delete extra columns for old replicas. After that,
the column info will be updated by the following line:

https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java#L363.

For example, previous it has 4 replicas and later it is changed to 3. The logic 
will delete column for replica number 4, and the above line will update replica 
from 1 to 3. I think the logic is correct here. Thanks. 

> Modifying a table descriptor to enable replicas does not create replica 
> regions
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-18490
>                 URL: https://issues.apache.org/jira/browse/HBASE-18490
>             Project: HBase
>          Issue Type: Bug
>          Components: Region Assignment
>    Affects Versions: 1.3.1, 1.2.6, 2.0.0-alpha-1
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: TestRegionReplicasWithRestartScenarios.java
>
>
> After creating a table, if we try to modify the table to enable region 
> replication, the new Htable Descriptor is not taken into account and the 
> table is enabled again with default single region.
> Ping [~enis], [~tedyu], [~devaraj].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to