[
https://issues.apache.org/jira/browse/HBASE-18647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136598#comment-16136598
]
Hadoop QA commented on HBASE-18647:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
27s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
32m 57s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
3s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 45m 31s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18647 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12883041/HBASE-18647.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux ded4d308ead8 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 05f07f6 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8227/testReport/ |
| modules | C: hbase-rest U: hbase-rest |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8227/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Parameter cacheBlocks does not take effect in REST API for scan
> ---------------------------------------------------------------
>
> Key: HBASE-18647
> URL: https://issues.apache.org/jira/browse/HBASE-18647
> Project: HBase
> Issue Type: Bug
> Components: REST
> Affects Versions: 2.0.0, 3.0.0, 1.4.0
> Reporter: Guangxu Cheng
> Assignee: Guangxu Cheng
> Attachments: HBASE-18647.patch
>
>
> Assign the parameter SCAN_BATCH_SIZE to the variable cacheBlocks incorrectly.
> And cacheBlocks has never been used.
> {code:title=TableResource.java|borderStyle=solid}
> @Path("{scanspec: .*[*]$}")
> public TableScanResource getScanResource(
> final @PathParam("scanspec") String scanSpec,
> @DefaultValue(Integer.MAX_VALUE + "")
> @QueryParam(Constants.SCAN_LIMIT) int userRequestedLimit,
> @DefaultValue("") @QueryParam(Constants.SCAN_START_ROW) String startRow,
> @DefaultValue("") @QueryParam(Constants.SCAN_END_ROW) String endRow,
> @DefaultValue("") @QueryParam(Constants.SCAN_COLUMN) List<String>
> column,
> @DefaultValue("1") @QueryParam(Constants.SCAN_MAX_VERSIONS) int
> maxVersions,
> @DefaultValue("-1") @QueryParam(Constants.SCAN_BATCH_SIZE) int
> batchSize,
> @DefaultValue("0") @QueryParam(Constants.SCAN_START_TIME) long
> startTime,
> @DefaultValue(Long.MAX_VALUE + "") @QueryParam(Constants.SCAN_END_TIME)
> long endTime,
> @DefaultValue("true") @QueryParam(Constants.SCAN_BATCH_SIZE) boolean
> cacheBlocks,
> @DefaultValue("false") @QueryParam(Constants.SCAN_REVERSED) boolean
> reversed,
> @DefaultValue("") @QueryParam(Constants.SCAN_FILTER) String
> paramFilter) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
