[ 
https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136847#comment-16136847
 ] 

Mike Drob commented on HBASE-18621:
-----------------------------------

{code}
+ * ClusterStatus status = admin.getClusterStatus(
+ *                                Options.createOptionsExcludeAllStatus()
+ *                                       .include(Status.LIVE_SERVERS);
{code}
nit: indent is off

Do Options and Status need {{InterfaceAudience}} annotations, or are they 
assumed to inherit from ClusterStatus?

Instead of storing a large number of booleans, why don't we use an {{EnumSet}}. 
Adding/Removing/Checking elements is not as fast as checking a boolean, but 
still very fast and would simplify some methods like reset() and grep().

> Refactor ClusterOptions before applying to code base
> ----------------------------------------------------
>
>                 Key: HBASE-18621
>                 URL: https://issues.apache.org/jira/browse/HBASE-18621
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Reid Chan
>            Assignee: Reid Chan
>         Attachments: HBASE-18621.master.001.patch, 
> HBASE-18621.master.002.patch, HBASE-18621.master.003.patch
>
>
> So far, ClusterStatus.Options is not so clean that can be applied to code 
> base.
> Refactoring it before next move.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to