[
https://issues.apache.org/jira/browse/HBASE-18532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136905#comment-16136905
]
Ted Yu commented on HBASE-18532:
--------------------------------
{code}
+ if (buf.getBlockType().isData())
+ dataBlockElements.incrementAndGet();
{code}
Please enclose the second line in curly braces.
I ran the patch thru test suite.
There was no test failure related to the patch.
> Improve cache related stats rendered on RS UI
> ---------------------------------------------
>
> Key: HBASE-18532
> URL: https://issues.apache.org/jira/browse/HBASE-18532
> Project: HBase
> Issue Type: Improvement
> Components: regionserver, UI
> Affects Versions: 1.1.2
> Reporter: Biju Nair
> Assignee: Biju Nair
> Attachments: COMBINED-STATS.PNG, HBASE-18532-1.1.2.PATCH,
> HBASE-18532.PATCH, HBASE-18532-V1.0.PATCH, L1-STATS.PNG, L2-STATS.PNG
>
>
> The stats currently rendered for L1 and L2 cache are incorrect. Refer to the
> attached screenshots of stats from a cluster showing the combined cache
> stats, L1 stats and L2 stats. For e.g. the combined stats shows 38 GB used
> for cache while if we sum size of L1 and L2 cache the value is way less. One
> way we can improve this is to use the same stats used to populate the
> combined stats to render the values of L1 & L2 cache. Also for usability we
> can remove the table with details with BucketCache buckets from the L2 cache
> stats since this is going to be long for any installation using L2 cache.
> This will help in understanding the cache usage better. Thoughts? If there
> are no concerns will submit a patch.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
