[jira] [Comment Edited] (HBASE-17614) Move Backup/Restore into separate module

[Josh Elser (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137441#comment-16137441
 ] 

Josh Elser edited comment on HBASE-17614 at 8/22/17 9:33 PM:
-------------------------------------------------------------

{noformat}
Running org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 56.919 sec <<< 
FAILURE! - in org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner
testBackupLogCleaner(org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner)
  Time elapsed: 54.294 sec  <<< FAILURE!
java.lang.AssertionError: expected:<0> but was:<1>
        at 
org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner.testBackupLogCleaner(TestBackupLogCleaner.java:94)
{noformat}

with a change of

{noformat}
diff --git 
a/hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/master/TestBackupLogCleaner.java
 
b/hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/master/TestBackupLogCleaner.java
index 5f72f458b9..e888f98f8e 100644
--- 
a/hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/master/TestBackupLogCleaner.java
+++ 
b/hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/master/TestBackupLogCleaner.java
@@ -18,6 +18,7 @@

 package org.apache.hadoop.hbase.backup.master;

+import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;

@@ -90,7 +91,7 @@ public class TestBackupLogCleaner extends TestBackupBase {
       deletable = cleaner.getDeletableFiles(walFiles);
       // We can delete wal files because they were saved into backup system 
table table
       size = Iterables.size(deletable);
-      assertTrue(size == walFiles.size());
+      assertEquals(size, walFiles.size());

       List<FileStatus> newWalFiles = 
getListOfWALFiles(TEST_UTIL.getConfiguration());
       LOG.debug("WAL list after full backup");
{noformat}


was (Author: elserj):
{noformat}
Running org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 56.919 sec <<< 
FAILURE! - in org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner
testBackupLogCleaner(org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner)
  Time elapsed: 54.294 sec  <<< FAILURE!
java.lang.AssertionError: expected:<0> but was:<1>
        at 
org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner.testBackupLogCleaner(TestBackupLogCleaner.java:94)
{noformat}

> Move Backup/Restore into separate module 
> -----------------------------------------
>
>                 Key: HBASE-17614
>                 URL: https://issues.apache.org/jira/browse/HBASE-17614
>             Project: HBase
>          Issue Type: Task
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>            Priority: Blocker
>              Labels: backup
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, 
> HBASE-17614-v3.patch, HBASE-17614-v4.patch
>
>
> Move all the backup code into separate hbase-backup module.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)