[
https://issues.apache.org/jira/browse/HBASE-15982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137464#comment-16137464
]
stack commented on HBASE-15982:
-------------------------------
.003 is cleanup. More convinced that this the way to go going forward; i.e. no
fancy Service stuff in ReplicationEndpoint, just simple start/stop stuff. Let
me look see at Replication Interface changes wanted elsewhere to see if can
integrate as part of this breaking change before 2.0.
> Interface ReplicationEndpoint extends Guava's Service
> -----------------------------------------------------
>
> Key: HBASE-15982
> URL: https://issues.apache.org/jira/browse/HBASE-15982
> Project: HBase
> Issue Type: Bug
> Reporter: Andrew Purtell
> Assignee: stack
> Priority: Blocker
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-15982.master.001.patch,
> HBASE-15982.master.002.patch, HBASE-15982.master.003.patch
>
>
> We have Guava's Service leaking into the LimitedPrivate interface
> ReplicationEndpoint:
> {code}
> public interface ReplicationEndpoint extends Service,
> ReplicationPeerConfigListener
> {code}
> This required a private patch when I updated Guava for our internal
> deployments. This is going to be a problem for us for long term maintenance
> and implenters of pluggable replication endpoints. LP is only less than
> public by a degree. We shouldn't leak types from third part code into either
> Public or LP APIs in my opinion. Let's fix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
