[
https://issues.apache.org/jira/browse/HBASE-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184754#comment-13184754
]
stack commented on HBASE-5179:
------------------------------
I think getDeadServersInProgress is better than getDeadServersBeingProcessed
since it relates to areDeadServersInProgress (I can fix this on commit -- would
also change name of the Collection in DeadServers so its inProgress).
Yeah, would be interested in notion that we do this server checking inside in
ServerManager so when you ask for onlineServers, this stuff has been done for
you already... or is thought that ServerManager need not know about
'handlers'.... that HMaster only should have to know whats running under it (A
ServerManager and handlers such as ServerShutdownHandler).
> Concurrent processing of processFaileOver and ServerShutdownHandler may
> cause region is assigned before completing split log, it would cause data loss
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5179
> URL: https://issues.apache.org/jira/browse/HBASE-5179
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.2
> Reporter: chunhui shen
> Assignee: chunhui shen
> Attachments: 5179-90.txt, 5179-90v2.patch, 5179-v2.txt, 5179-v3.txt,
> 5179-v4.txt, hbase-5179.patch, hbase-5179v5.patch
>
>
> If master's processing its failover and ServerShutdownHandler's processing
> happen concurrently, it may appear following case.
> 1.master completed splitLogAfterStartup()
> 2.RegionserverA restarts, and ServerShutdownHandler is processing.
> 3.master starts to rebuildUserRegions, and RegionserverA is considered as
> dead server.
> 4.master starts to assign regions of RegionserverA because it is a dead
> server by step3.
> However, when doing step4(assigning region), ServerShutdownHandler may be
> doing split log, Therefore, it may cause data loss.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
