[
https://issues.apache.org/jira/browse/HBASE-18673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140927#comment-16140927
]
stack commented on HBASE-18673:
-------------------------------
Took a look.
ProtobufLogReader has a Phoenix client annotation. This is probably why we left
it as unshaded. It is also mentioned as the reader in:
<property>
<name>hbase.regionserver.hlog.reader.impl</name>
<value>org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader</value>
<description>The WAL file reader implementation.</description>
</property>
I changed the usage to be internal shaded. We use two classes, neither of which
is let out... both are internal. One to do size calc and the other an exception
we do not let out.
On HBaseFsck, I purged its use of SE. As you say, it is not used. I think it ok
to change this. I've added to our incompat list a note that we should ensure an
HBaseFSCK1 does not run against a hbase2 cluster.
I left PBType. It is 'public'. It is an instance of us exposing pb as part of
our public API but it all apart from hbase internals; a facility rather than
integral. Not an issue at the mo, not for 2.0 at least.
Let me put up a patch for the above items.
> Some more unwanted reference to unshaded PB classes
> ---------------------------------------------------
>
> Key: HBASE-18673
> URL: https://issues.apache.org/jira/browse/HBASE-18673
> Project: HBase
> Issue Type: Improvement
> Reporter: Anoop Sam John
> Priority: Minor
> Fix For: 2.0.0-alpha-3
>
>
> ProtobufLogReader - Seems using Unshaded CIS which seems a miss
> HBaseFsck - Some public methods throw PB ServiceException. Its strange. No
> code within that throws this.
> Public exposed PBType class. I dont know what this type allows the users to
> do. Make their own Type? If so the Unshaded might be ok.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
