[
https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142414#comment-16142414
]
Appy commented on HBASE-18640:
------------------------------
The last piece remaining is TestImportExport#testImport94Table failure.
For some reason, {{URL url = TestImportExport.class.getResource(name)}} is
resolving to this URL
{{2017-08-25 16:17:25,672 INFO [main] mapreduce.TestImportExport(244):
URL:jar:file:/Users/appy/.m2/repository/org/apache/hbase/hbase-server/3.0.0-SNAPSHOT/hbase-server-3.0.0-SNAPSHOT-tests.jar!/org/apache/hadoop/hbase/mapreduce/exportedTableIn94Format}}
Maybe because when class loader looks for the
{{org/apache/hadoop/hbase/mapreduce/}} package, in finds it it hbase-server
first?
> Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
> -----------------------------------------------------------------------
>
> Key: HBASE-18640
> URL: https://issues.apache.org/jira/browse/HBASE-18640
> Project: HBase
> Issue Type: Bug
> Reporter: Appy
> Assignee: Appy
> Attachments: HBASE-18640.master.001.patch,
> HBASE-18640.master.002.patch, HBASE-18640.master.003.patch,
> HBASE-18640.master.003.patch, HBASE-18640.master.004.patch,
> HBASE-18640.master.004.patch, HBASE-18640.master.005.patch,
> HBASE-18640.master.006.patch
>
>
> (Couldn't find another dedicated jira, so creating new one).
> Uploaded patch which is moving ~60 files to the new module. Few notes:
> - The classes remaining in hbase-server are the ones which are intensively
> coupled with visibility labels/wal/filesystem/hfile. These can not be
> migrated to new module until corresponding subcomponents are untangled out of
> hbase-server into their own separate modules.
> - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to
> hbase-mapreduce module. Given these dependency constraints, one way would be
> having a separate module for tests:
> hbase-mapreduce <---- hbase-server <------- hbase-mapreduce-tests
> Imo, this makes sense and looks fine.
> The only issue is - yetus' pre-commit. It won't run tests in
> hbase-mapreduce-tests module if something changed in just hbase-mapreduce.
> However, yetus' limitation shouldn't warrant against the idea.
> So i'd say that we should go that way, unless there are better suggestions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
